Ensure gathering data messages in WP dashboard widget and admin bar UI are only shown when applicable

[felixarntz]

Follow-up to #4085 and #4086: Those two issues only encompassed updating the UI in the Site Kit dashboard accordingly. The WP dashboard widget and the admin bar UI still surface the "gathering data" messages even in cases where the services aren't gathering data, but rather the site simply has 0 views/impressions. This issue is about fixing the UI in those areas accordingly as well.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The WP dashboard widget should show 0s instead of the blue "gathering data" banners for Search Console impressions and clicks respectively if Search Console isn't gathering data (see isGatheringData selector from Ensure Search Console widgets only show "Gathering data" box when API is actually gathering data #4085).
• The WP dashboard widget should show 0s instead of the blue "gathering data" banners for Analytics visitors and avg. time on page respectively if Analytics isn't gathering data (see isGatheringData selector from Ensure Analytics widgets only show "Gathering data" box when API is actually gathering data #4086).
  • Related to Missing Unit Characters on Zero Data Widgets #4238, it should be ensured the units are included, i.e. "Avg. time on page" should say "0s" and not just "0".
• The WP dashboard widget should not display the popular pages table at all if its Analytics report is only 0s - the "gathering data" message in its place should only be displayed if the service is truly gathering data. It doesn't add anything in that case, and showing the two Analytics-based 0 values (see above point) is sufficient to indicate that the site doesn't have any views at all.
• The WP admin bar UI should show 0s instead of the blue "gathering data" banners for Search Console impressions and clicks respectively if Search Console isn't gathering data (see isGatheringData selector from Ensure Search Console widgets only show "Gathering data" box when API is actually gathering data #4085).
• The WP admin bar UI should show 0s instead of the blue "gathering data" banners for Analytics visitors and sessions respectively if Analytics isn't gathering data (see isGatheringData selector from Ensure Analytics widgets only show "Gathering data" box when API is actually gathering data #4086).
• Storybook coverage for both areas showing purely 0s should be included.

Implementation Brief

• Update the following components to display 0s instead of the blue "gathering data" banners if Search Console isn't gathering data anymore. Use the similar approach from Ensure Search Console widgets only show "Gathering data" box when API is actually gathering data #4085 to determine the gathering status of the Search Console module.
  • WPDashboardClicks
  • WPDashboardImpressions
  • AdminBarClicks
  • AdminBarImpressions
• Update the following components to display 0s instead of the blue "gathering data" banners if Analytics isn't gathering data anymore. Use the similar approach from Ensure Analytics widgets only show "Gathering data" box when API is actually gathering data #4086 to determine the gathering status of the Analytics module.
  • WPDashboardUniqueVisitors
  • WPDashboardSessionDuration
  • AdminBarSessions
  • AdminBarUniqueVisitors
• Update the WPDashboardPopularPages component to return null if Analytics is still gathering data.

Test Coverage

• N/A

QA Brief

• Create a new jurassic ninja site.
• Install the plugin and connect it.
• Verify that the widgets on the admin bar (frontend) and the widgets on the main WP dashboard show zero states.
• Wait a few days and check again.
• Confirm that now widgets don't display zero states, but charts with zeros.

Changelog entry

• Update WordPress dashboard widget and admin bar stats to display zero states for Search Console/Analytics only when the respective service is gathering data.

[felixarntz]

FYI @eugene-manuilov :)

[eugene-manuilov]

@felixarntz this is ready for review.

[felixarntz]

@eugene-manuilov IB ✅ , just want to clarify one thing: Let's make sure we also keep the isZeroReport checks in place like we have done in the dashboard widgets, i.e. the check everywhere should be like isZeroReport( report ) && isGatheringData().