UX/UI issue for 'Who can manage view access' inactive dropdowns

[eclarke1]

Feature Description

Bug bash issue: https://app.asana.com/0/1202258919887896/1202406665934847 please refer to Asana issue for background

When you have a secondary admin user and went back to the Dashboard sharing & permissions screen, the Who can manage view access dropdown is inactive for PageSpeed and Idea Hub. Looking at the AC this is expected but could we not have a scenario where an admin does not want to share these modules with all admins? If this isn't a scenario, then should we hide these dropdown's to avoid confusion? I feel this needs discussing.

These are what are referred to as "Shared ownership modules" which are different than others because they don't involve a specific "owned" entity on the service side, the ownership is more of a detail related to sharing (only owned modules can be shared with others). For these, ownership is set when the roles are changed which can be managed by all authenticated admins which is why the dropdowns for these are disabled.

Maybe it's worth having some kind of tooltip or other message there indicating why these can't be changed? I don't think it's obvious to users that these modules are any different from the others.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Replace the disabled dropdown with plain text that reads: "Any admin signed in with Google" (this is the new wording, see: Clarify "All admins" wording in Dashboard Sharing settings #5374). Because this can never be interacted with, removal of the <select> tag will clarify the usage for users by never setting up the expectation that this setting can be changed.
• After the text added above, add a tooltip to "shared ownership" modules shared with all admins that reads: This service requires general access to Google APIs rather than access to a specific user-owned property/entity, so view access is manageable by any admin signed in with Google.
• This text + tooltip should be similar to the text + tooltip used when the module is owned by another user, eg:

Implementation Brief

• In assets/js/components/dashboard-sharing/DashboardSharingSettings/Module.js:
  • locate the <Select /> component responsible for showing the view access options.
  • Inside .googlesitekit-dashboard-sharing-settings__column--manage, prior to showing the <Select /> component, start a new paragraph for the plain text. This should only show up if sharedOwnershipModule is true.
  • Make a copy of the existing .googlesitekit-dashboard-sharing-settings__note paragraph as indicated in the last part of the AC to compose this plain text. Simply replace the text of the paragraph (and the tooltip inside) to match what's included in the AC.
  • Update the condition for displaying the <Select />: it should only show up when sharedOwnershipModule is false and hasOwnedModule is true.

Test Coverage

• No new tests required.
• Update VRT images if applicable.

QA Brief

• Enable dashboardSharing flag from the tester plugin.
• Go to Site Kit Dashboard.
• Open the Dashboard Sharing settings modal.
• Ensure that the "Who can manage view access" column for shared ownership modules (e.g. PageSpeed and Idea Hub) doesn't have the dropdown. It should instead have plain text with a tooltip as described in the AC.

Changelog entry

• Display a message with tooltip instead of disabled Dashboard Sharing view management dropdown.

[aaemnnosttv]

@felixarntz @marrrmarrr should we instead maybe replace the select boxes here with text (like we do for modules owned by other admins) to say simply "Manageable by all authenticated admins" ?

[felixarntz]

@aaemnnosttv +1, I think that's a gread idea. I'd say the term "authenticated" we should probably only include though in combination with also changing the "All admins" dropdown label to "All authenticated admins" (see other bug bash discussion).

[tofumatt]

@bethanylang Since you originally pointed this out and suggested changes to make it clear that users can't edit these settings, can you check the Acceptance Criteria here and see if they would improve this scenario?

If it's good just leave a comment saying so and feel free to move this over to the Implementation Brief column, but if not please let me know any better wording to use or an approach you think is better 🙂

[mxbclang]

@tofumatt LGTM, thank you!

[aaemnnosttv]

@bethanylang I've revised the language a bit, would you please take another look?

[mxbclang]

@aaemnnosttv Like this even more, thank you!

[tofumatt]

IB ✅ looks good.

Thanks for the updated text @aaemnnosttv, it's way better 👍🏻

[mohitwp]

QA Update ✅

Verified 👍

• "Who can manage view access" column for shared ownership modules (e.g. PageSpeed and Idea Hub) doesn't have the dropdown
• It has plain text with a tooltip as described in the AC.
• This text and tooltip is same for all admins.