Clarify "All admins" wording in Dashboard Sharing settings

[eclarke1]

Feature Description

In the "Who can manage view access" section of Dashboard Sharing settings, the wording "All admins" needs more clarification. It is easily misread as "All WordPress admins" but it really means "All WordPress Admins who have authenticated with Site Kit + their Google Account". We should clarify this wording to avoid confusion.

The wording in question:

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The wording in the "Who can manage view access" dropdown should be updated from "All admins" to "Any admin signed in with Site Kit"

Implementation Brief

• Update

  site-kit-wp/assets/js/components/dashboard-sharing/DashboardSharingSettings/Module.js

  Line 68 in 26304ca

  label: __( 'All Admins', 'google-site-kit' ),

  to "Any admin signed in with Site Kit"

Test Coverage

• No news tests needed.

QA Brief

• Make sure the dashboardSharing feature flag is enabled.
• Make sure there is more than one admin in the site (otherwise the "Who can manage view access" column will not show up).
• Go to Google Site Kit Dashboard.
• Open the Dashboard Sharing settings modal.
• Make sure the "All Admins" option now says "Any admin signed in with Google".

Changelog entry

• Clarify "All admins" wording in Dashboard Sharing settings.

[eugene-manuilov]

IB ✔️

[aaemnnosttv]

@tofumatt @felixarntz would it be more clear if we said "any admin signed-in with Google" rather than with "Site Kit"? I feel the latter may be a bit easier to misinterpret.

Thoughts @bethanylang ?

[eclarke1]

+1 to language being orientated around 'Google' account, makes more sense to me

[nfmohit]

The current PR attached to this issue is set to replace "All Admins" with "Any admin signed in with Google" according to the above discussion. I'm happy to change it if we decide otherwise.

While we're on the discussion about copy, @aaemnnosttv @tofumatt Do you think it is necessary to capitalise (capital for the first letter of every word) this sentence like it was before ("All Admins") and the other option ("Only Me") for consistency?

[techanvil]

The current PR attached to this issue is set to replace "All Admins" with "Any admin signed in with Google" according to the above discussion. I'm happy to change it if we decide otherwise.

While we're on the discussion about copy, @aaemnnosttv @tofumatt Do you think it is necessary to capitalise (capital for the first letter of every word) this sentence like it was before ("All Admins") and the other option ("Only Me") for consistency?

Hi @nfmohit, I don't think we should capitalise this sentence, as we don't generally capitalise sentences like this, only phrases/titles, generally of 2-4 words.

However you raise a good point about consistency. I think we should instead update the casing of "Only Me" to be "Only me", for consistency here.

[wpdarren]

QA Update: ✅

Verified:

• the "All Admins" option now says "Any admin signed in with Google".
• tested on desktop and smaller screen sizes, i.e. iOS and Android mobiles.

Screenshots