-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate module owner's username if too long for view-only menu #5500
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Comments
wpdarren
added
Type: Enhancement
Improvement of an existing feature
UX
Issues that require UX input
labels
Jul 4, 2022
aaemnnosttv
added
P2
Low priority
Good First Issue
Good first issue for new engineers
and removed
UX
Issues that require UX input
labels
Aug 2, 2022
aaemnnosttv
changed the title
Add ellipsis if admin username is more than 25 characters on view only menu
Truncate module owner's username if too long for view-only menu
Aug 2, 2022
@aaemnnosttv we should also add the |
Good call @eugene-manuilov – I'll add this as well 👍 |
Thanks, @aaemnnosttv. IB ✔️ |
18 tasks
tofumatt
added a commit
that referenced
this issue
Aug 22, 2022
…r-username Truncate module owner username in view-only menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First Issue
Good first issue for new engineers
P2
Low priority
Type: Enhancement
Improvement of an existing feature
Bug Description
While testing #5381 I identified a small observation/enhancement that was out of scope.
On Dashboard Sharing, in the view only menu, when you have an administrator with a username that is 25 characters or more, it causes problems with the layout. I am wondering if we should cut the username off at a certain amount of characters with ellipsis like we do on other parts of the plugin. As you can see from the screenshot on desktop it goes right to the edge. (and the same with mobile.). I realise 25 characters is a silly amount of characters for a username, but users be users! 😄
Screenshot
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The truncated element should show the full untruncated username on hover
Implementation Brief
.googlesitekit-view-only-menu__service--owner
with the following additional CSS rulestext-overflow: ellipsis
overflow: hidden
strong
tag) with atitle
attribute with the same value so that the full username is visible on hoverTest Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: