-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in DashboardNavigation
stories
#5585
Comments
Hey @nfmohit, this IB looks good. One minor tweak I would suggest is to use the filename |
Very valid suggestion. I've updated the IB. Thank you @techanvil! |
Thanks @nfmohit! IB ✅ |
…tion-story Move `setupDefaultChips` to a seperate file.
QA:Eng Verified ✅
|
Bug Description
VRT runs currently show the following
ReferenceError
that happens several times during a test run:This is from the stories module importing a helper from a Jest test file which includes calls to
describe
as a side-effect. This is provided automatically by Jest so it errors as undefined in VRT runs.Steps to reproduce
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
describe is not defined
error should not be raised during VRT runsImplementation Brief
setupDefaultChips()
function into the story file from a non-Jest file so thatdescribe
isn't called as a side-effect.assets/js/components/DashboardNavigation
:test-utils.js
. In this file:DashboardNavigation test utility functions.
.setupDefaultChips()
function fromindex.test.js
to this file (including relevant imports and JSDoc comments).index.test.js
, importsetupDefaultChips()
fromtest-utils.js
. Remove unnecessary dependenciesindex.stories.js
, importsetupDefaultChips()
fromtest-utils.js
instead ofindex.test.js
.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: