-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Key metrics Setup CTA #6210
Comments
IB ✅ |
Enhance/#6210 - Design Key metrics Setup CTA
QA Update
|
@mohitwp Just FYI, for Question 1, we have noticed these differences and included a fix for them in the PR for #6265. Thanks! CC: @hussain-t |
Thanks, @mohitwp. Regarding your questions:
Yes, this is expected to be consistent with other banners. It will be fixed in #6265 as @nfmohit mentioned.
This is due to the SVG image height. I will create a follow-up PR to fix it shortly. We don't need to create a new ticket. |
Enhance/#6210 - Fix SVG height for the narrow viewports
QA Update ✅
|
Feature Description
The Key metrics Setup CTA placeholder component created in #6209 should be designed fully in this issue.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
SettingsAdmin
once Enhance/6261 key metrics settings toggle #6718 is merged.KeyMetricsCTA
instead of the currentUserInputSettings
isDismissible
prop.<section>
element having the class.googlesitekit-plugin .googlesitekit-setup__wrapper
.<section>
component, construct a<Grid />
component having two<Row />
components, one for content and the other for the footerMaybe later
action.<Row />
component, place two<Cell />
components, each having half width of their container.<Cell />
component should have the text content and the actions (Get tailored metrics
<Button />
andI'll pick metrics myself
<Link />
). Style the elements matching the Figma design.Get tailored metrics
<Button />
component should take the user to the User Input questionnaire. The URL for it can be obtained using thegetAdminURL
selector of thecore/site
store, passinggooglesitekit-user-input
to it.I'll pick metrics myself
<Link />
component should do nothing at this point.Ghost cards
element from the Figma design, and place it in the second<Cell />
component. To ensure this SVG placement is graceful, you can follow the implementation inassets/js/modules/idea-hub/components/common/IdeaHubPromptSVG.js
.<Row />
component, place theMaybe later
<Link />
component inside a full-width<Cell />
component. It should do nothing at this point, its action will be implemented as a part of Implement Key metrics CTA dismissal #6232.Test Coverage
Get tailored metrics
<Button />
component.QA Brief
userInput
feature flag and set up Site Kit.Get tailored metrics
button navigates the user to the user input questionnaire screen.Verify the layout in the following viewports
Upto 600px
601px - 960px
961px - 1280px
1281px and above
Changelog entry
The text was updated successfully, but these errors were encountered: