Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GA4 AdminBarUniqueVisitors #6214

Closed
aaemnnosttv opened this issue Nov 29, 2022 · 4 comments
Closed

Create GA4 AdminBarUniqueVisitors #6214

aaemnnosttv opened this issue Nov 29, 2022 · 4 comments
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Nov 29, 2022

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A new component AdminBarUniqueVisitorsGA4 should be created based on the existing AdminBarUniqueVisitors
  • The component should source its report data from the analytics-4 store
  • No changes should be made in the dashboard yet
  • Storybook stories should be added to cover the following cases (with and without a current entity URL set: example):
    • Loading
    • Gathering data ("Data unavailable")
    • Zero data (data available but metric is 0)
    • Error
    • Ready (data available and non-zero)

Implementation Brief

  • Once Add getReport selector for GA4 #6173 and Introduce factory for Analytics 4 response mock data #6174 have been merged.
  • Create assets/js/components/adminbar/AdminBarUniqueVisitorsGA4.js which exports the AdminBarUniqueVisitorsGA4 functional component.
    • Component should be similar to the one in assets/js/components/adminbar/AdminBarUniqueVisitors.js with the following updates:
      • Replace occurrences of the Analytics data store (MODULES_ANALYTICS) by the GA4 Analytics data store (MODULES_ANALYTICS_4).
      • Replace the metrics and dimensions by their GA4 counterparts as per the doc here, including the metric names.
    • Stories should be within assets/js/components/adminbar/AdminBarUniqueVisitorsGA4.stories.js and make use of the Analytics 4 response mock data added from Introduce factory for Analytics 4 response mock data #6174
      • Refer to the AC for the different stories to be added.

Test Coverage

  • No new tests to be added.

QA Brief

  • This is currently only testable in Storybook.
  • Check the stories under VIEWS > AdminBarApp > AdminBarUniqueVisitorsGA4. These should be broadly in line with the existing UA version under VIEWS > AdminBarApp > AdminBarUniqueVisitors, except with the following additional stories:
    • Loading
    • Error
  • PR Storybook (will be deleted when merged to develop).
  • develop Storybook.
  • main Storybook.

Screenshots

Screenshot 2023-03-06 at 2 08 08 PM
Screenshot 2023-03-06 at 2 08 01 PM
Screenshot 2023-03-06 at 2 07 55 PM
Screenshot 2023-03-06 at 2 07 48 PM
Screenshot 2023-03-06 at 2 07 42 PM

Changelog entry

  • Add the Analytics 4 version of the unique visitors tile in the admin bar.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Nov 29, 2022
@aaemnnosttv aaemnnosttv self-assigned this Nov 29, 2022
@aaemnnosttv aaemnnosttv removed their assignment Dec 9, 2022
@asvinb asvinb assigned asvinb and unassigned asvinb Dec 13, 2022
@techanvil techanvil self-assigned this Dec 19, 2022
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil removed their assignment Dec 19, 2022
@eclarke1 eclarke1 added P0 High priority and removed P1 Medium priority labels Dec 22, 2022
@derweili derweili self-assigned this Feb 1, 2023
@derweili
Copy link
Collaborator

derweili commented Feb 2, 2023

As discussed in Slack and Engineering Stand-up, waiting for #6514 to be merged, before continuing on this.

@mxbclang
Copy link

mxbclang commented Feb 2, 2023

Thanks @derweili, unassigned this from the current sprint and from you for now

@hussain-t hussain-t self-assigned this Mar 2, 2023
@hussain-t hussain-t removed their assignment Mar 6, 2023
@eugene-manuilov eugene-manuilov self-assigned this Mar 6, 2023
eugene-manuilov added a commit that referenced this issue Mar 6, 2023
…e-visitors

Enhance/#6214 - Create GA4 `AdminBarUniqueVisitors`
@eugene-manuilov eugene-manuilov removed their assignment Mar 6, 2023
@mohitwp mohitwp self-assigned this Mar 6, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 7, 2023

QA Update ✅

image

image

image

image

image

@mohitwp mohitwp removed their assignment Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

9 participants