Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistent contextual notices about the Optimize sunset #6468

Closed
aaemnnosttv opened this issue Jan 27, 2023 · 7 comments
Closed

Add persistent contextual notices about the Optimize sunset #6468

aaemnnosttv opened this issue Jan 27, 2023 · 7 comments
Labels
Exp: SP Module: Optimize Google Optimize module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Jan 27, 2023

Feature Description

In addition to the banner notification in #6467, we will also add a number of contextual notices to inform users about the Optimize sunset.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • An inline warning should be added to the Optimize module's tile on the Connect More Services tab, similar to the warning shown when Analytics is not active (reference)

    Optimize will no longer work after September 30, 2023 Learn more

  • An inline warning should be added to the top of the Optimize module's setup, settings view, and settings edit components (example)

    Optimize will no longer work after September 30, 2023 and will be removed from subsequent versions of Site Kit after that date. Learn more

  • Learn more URL (all instances): https://support.google.com/optimize/answer/12979939

  • These warnings are to be static, and non-dismissible

Implementation Brief

  • Using assets/js/components/settings/SetupModule.js,
    • Just after the ModuleSettingsWarning component, render the text from the first bullet point from the AC if slug is optimize.
      • The rendered markup should be similar to assets/js/components/notifications/ModuleSettingsWarning.js including the icon.
  • Create assets/js/modules/optimize/components/common/OptimizeSunsetNotice.js which exports the OptimizeSunsetNotice functional component.
    • It should render the text from the second bullet point from the AC using the SettingsNotice component with the type set to TYPE_WARNING.
  • Using assets/js/modules/optimize/components/setup/SetupMain.js, assets/js/modules/optimize/components/settings/SettingsView.js and assets/js/modules/optimize/components/settings/SettingsEdit.js, render OptimizeSunsetNotice in first position before any other text.
  • To generate the learn more URL, query the core/site datastore via the getGoogleSupportURL selector.

Test Coverage

  • No new tests to be added.

QA Brief

  • Create a new site, connect the plugin with the Analytics module.
  • Go to the settings page and open the tab to connect modules.
  • Find the Optimize module in the list and ensure that you see the warning from AC.
  • Connect the Optimize module and ensure that you see the new warning from AC on the setup form.
  • Once the module is connected go to the settings page and open the Optimize module settings view.
  • Ensure that you see the same warning as in AC.
  • Edit the Optimize module settings to see the edit for and ensure that there is the same warning on the form.

Changelog entry

  • Add notice about Optimize sunset to settings and setup screens.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature Module: Optimize Google Optimize module related issues labels Jan 27, 2023
@marrrmarrr
Copy link
Collaborator

Updated the copy here.

@marrrmarrr marrrmarrr removed their assignment Feb 2, 2023
@asvinb asvinb self-assigned this Feb 3, 2023
@asvinb asvinb added the Exp: SP label Feb 3, 2023
@asvinb asvinb removed their assignment Feb 3, 2023
@eugene-manuilov eugene-manuilov self-assigned this Feb 3, 2023
@eugene-manuilov
Copy link
Collaborator

Using assets/js/components/setup/ModuleSetup.js,

  • Render OptimizeSunsetNotice if moduleSlug is optimize.

@asvinb, we should render it in assets/js/modules/optimize/components/setup/SetupMain.js, shouldn't we?

@asvinb
Copy link
Collaborator

asvinb commented Feb 7, 2023

You're right @eugene-manuilov . IB updated 😁

@asvinb asvinb assigned eugene-manuilov and unassigned asvinb Feb 7, 2023
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Feb 7, 2023
@mxbclang mxbclang self-assigned this Feb 17, 2023
@mxbclang
Copy link

mxbclang commented Mar 9, 2023

Planning to schedule for Sprint 99, ending April 21.

@mxbclang mxbclang removed their assignment May 15, 2023
@eugene-manuilov eugene-manuilov self-assigned this May 23, 2023
@eugene-manuilov eugene-manuilov removed their assignment May 26, 2023
@tofumatt tofumatt assigned tofumatt and eugene-manuilov and unassigned tofumatt Jun 1, 2023
@eugene-manuilov eugene-manuilov removed their assignment Jun 2, 2023
@tofumatt tofumatt removed their assignment Jun 2, 2023
@wpdarren wpdarren self-assigned this Jun 6, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Jun 7, 2023

QA Update: ✅

Verified:

  • An inline warning appears in the Optimize module's tile on the Connect More Services tab.
  • An inline warning is added to the top of the Optimize module's setup screen.
  • An inline warning is added to the settings view, and settings edit components.
  • The copy is as per the AC, with the correct US date format consistent on all warnings.
  • The URLs on all warnings point to the one in the AC.
  • The warnings are to be static, and non-dismissible.

Completed testing on desktop and mobile viewports.

Note: I did observe the warnings were full-width where they were previously limited. #7140 will fix this.

Screenshots

image
image
image
image
image
image

@wpdarren wpdarren removed their assignment Jun 7, 2023
@aaemnnosttv
Copy link
Collaborator Author

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP Module: Optimize Google Optimize module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

7 participants