Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/6468 optimise warning #7092

Merged
merged 8 commits into from
Jun 2, 2023

Conversation

eugene-manuilov
Copy link
Collaborator

@eugene-manuilov eugene-manuilov commented May 25, 2023

Summary

Addresses issue:

Relevant technical choices

  • Updated the module requirements check functionality to allow us showing warnings and still let users to connect a module if the module throws an error with canActivate: true property.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions

This comment was marked as resolved.

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I tested it out and it works everywhere expected. Just one tweak for one of the translation strings and then we're good-to-go 👍🏻

Comment on lines 50 to 58
<div>
{ __(
'Optimize will no longer work after September 30, 2023.',
'google-site-kit'
) }{ ' ' }
<SupportLink path="/optimize/answer/12979939" external>
{ __( 'Learn more', 'google-site-kit' ) }
</SupportLink>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use createInterpolateElement instead, so the whitespace is part of the translation string, eg.

Suggested change
<div>
{ __(
'Optimize will no longer work after September 30, 2023.',
'google-site-kit'
) }{ ' ' }
<SupportLink path="/optimize/answer/12979939" external>
{ __( 'Learn more', 'google-site-kit' ) }
</SupportLink>
</div>
<div>
{ createInterpolateElement(
__(
'Optimize will no longer work after September 30, 2023. <SupportLink>Learn more</SupportLink>',
'google-site-kit'
),
SupportLink: <SupportLink path="/optimize/answer/12979939" external />
) }
</div>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tofumatt. Updated.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Build files for f145c33 have been deleted.

@tofumatt tofumatt merged commit 855cc5b into develop Jun 2, 2023
@tofumatt tofumatt deleted the enhancement/6468-optimise-warning branch June 2, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants