-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/6468 optimise warning #7092
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I tested it out and it works everywhere expected. Just one tweak for one of the translation strings and then we're good-to-go 👍🏻
assets/js/modules/optimize/index.js
Outdated
<div> | ||
{ __( | ||
'Optimize will no longer work after September 30, 2023.', | ||
'google-site-kit' | ||
) }{ ' ' } | ||
<SupportLink path="/optimize/answer/12979939" external> | ||
{ __( 'Learn more', 'google-site-kit' ) } | ||
</SupportLink> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use createInterpolateElement
instead, so the whitespace is part of the translation string, eg.
<div> | |
{ __( | |
'Optimize will no longer work after September 30, 2023.', | |
'google-site-kit' | |
) }{ ' ' } | |
<SupportLink path="/optimize/answer/12979939" external> | |
{ __( 'Learn more', 'google-site-kit' ) } | |
</SupportLink> | |
</div> | |
<div> | |
{ createInterpolateElement( | |
__( | |
'Optimize will no longer work after September 30, 2023. <SupportLink>Learn more</SupportLink>', | |
'google-site-kit' | |
), | |
SupportLink: <SupportLink path="/optimize/answer/12979939" external /> | |
) } | |
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tofumatt. Updated.
Build files for f145c33 have been deleted. |
Summary
Addresses issue:
Relevant technical choices
canActivate: true
property.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist