-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GA4 Activation Success Banner #6539
Comments
Looks good, just added a point about Moved to IB 👍🏻 |
IB ✅ |
…ion-banner Enhance/#6539 - Update GA4 Activation Success Banner
QA Update
|
Thanks for raising this, @mohitwp. IMHO, it looks much better without the graphic SVG on the smaller screens, as the image is more prominent. However, I would like to get @marrrmarrr opinion on this. This is how it looks on a smaller screen: |
@hussain-t @mohitwp agreed that the mobile version looks better without the graphic. Do we need to apply this in other cases as well? |
Thanks, @marrrmarrr. IMHO, yes, to keep it consistent. However, please note that some banners render the image on the left and some on the right. |
QA Update ✅
|
Feature Description
The GA4 Activation - Success Banner will need to be updated according to the Figma design. The major updates are:
Since the GA4 dashboard view isn't available right away, it might be a good idea to keep the update to the banner copy behind the
ga4Reporting
feature flag.Here is the relevant part in the design doc.
Here is a screenshot for visual aid:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
ga4Reporting
feature flag is enabled. Otherwise, it should keep showing the existing copy.WinImage
graphic should be updated according to the design.ga4Reporting
feature flag.Implementation Brief
Within
assets/js/modules/analytics-4/components/dashboard/ActivationBanner/SuccessBanner.js
:ga4Reporting
feature flag is enabled. If so replace the currentdescription
with the text as per Figma:description
: Google Analytics 4 has started collecting data for your site. As soon there is enough data, you'll be able to switch your Site Kit dashboard to show data from Google Analytics 4.learnMoreLabel
as per Figma:learnMoreLabel
: Learn more about Google Analytics 4assets/svg/graphics/
. Use this new SVG in place of the currentSuccessGreenSVG
component.Test Coverage
QA Brief
ga4Reporting
feature flag enabled.ga4Reporting
feature flag disabled.Changelog entry
The text was updated successfully, but these errors were encountered: