Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdSense Settings footer link takes user to 404 page #6647

Closed
kuasha420 opened this issue Feb 28, 2023 · 1 comment
Closed

AdSense Settings footer link takes user to 404 page #6647

kuasha420 opened this issue Feb 28, 2023 · 1 comment
Labels
Module: AdSense Google AdSense module related issues P0 High priority Type: Bug Something isn't working

Comments

@kuasha420
Copy link
Contributor

kuasha420 commented Feb 28, 2023

Bug Description

Identified as part of release testing for #6564 - Clicking on the AdSense settings footer page takes user to the AdSense start page. however this link has been changed from https://www.google.com/adsense/start to https://adsense.google.com/start. While there's a basic redirect in place for the above change in Google site, this only works for the plain URL. Since our link adds query parameter without adding a trailing slash, this doesn't work for us and users get a 404 page.

Steps to reproduce

  1. Go to AdSense Settings
  2. Click on See full details in AdSense
  3. See the link returns 404.

Additional Context

  • Plugin Version: 1.94.0

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • AdSense Settings Footer Link should take user to AdSense home page without resulting in a 404 error.
    • This can be accomplished by updating the AdSense modules homepage URL to https://adsense.google.com/start.

Implementation Brief

  • In Google\Site_Kit\Modules\AdSense class:
    • Update the homepage with the correct URL from AC in the return array of setup_info function.

Test Coverage

  • Fix any potential failing tests/snapshots.

QA Brief

  • The AdSense footer link should behave correctly.

Changelog entry

  • Update the AdSense homepage URL, fixing the link in the AdSense Settings footer.
@kuasha420 kuasha420 self-assigned this Feb 28, 2023
@kuasha420 kuasha420 added Type: Bug Something isn't working P0 High priority Module: AdSense Google AdSense module related issues labels Feb 28, 2023
@kuasha420 kuasha420 removed their assignment Feb 28, 2023
@techanvil techanvil assigned techanvil and unassigned techanvil Feb 28, 2023
@wpdarren wpdarren self-assigned this Feb 28, 2023
@wpdarren
Copy link
Collaborator

QA Update: ✅

Verified:

  • The AdSense link in the settings no longer 404's. I am redirected to https://adsense.google.com/start/?source=site-kit&url=https:%2F%2F195-0.instawp.xyz&pli=1&authuser=2
  • Went through all of the other external links on Site Kit settings to make sure they continue to function.

@wpdarren wpdarren removed their assignment Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: AdSense Google AdSense module related issues P0 High priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants