Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.95.0 #6564

Closed
aaemnnosttv opened this issue Feb 8, 2023 · 10 comments
Closed

Release 1.95.0 #6564

aaemnnosttv opened this issue Feb 8, 2023 · 10 comments
Labels
P0 High priority Type: Task Tasks which do not involve engineering

Comments

@aaemnnosttv
Copy link
Collaborator


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added Type: Task Tasks which do not involve engineering P0 High priority labels Feb 8, 2023
@aaemnnosttv aaemnnosttv self-assigned this Feb 8, 2023
@mohitwp mohitwp self-assigned this Feb 23, 2023
@aaemnnosttv
Copy link
Collaborator Author

I noticed an issue while testing but it does not appear to be a regression. I opened a new issue to fix it:

@techanvil techanvil self-assigned this Feb 24, 2023
@hussain-t hussain-t self-assigned this Feb 24, 2023
@hussain-t
Copy link
Collaborator

QA Verified ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Performed some ad-hoc testing.

@hussain-t hussain-t removed their assignment Feb 24, 2023
@kuasha420 kuasha420 self-assigned this Feb 26, 2023
@kuasha420
Copy link
Contributor

:QA: ✔️

  • Went through the release checklist.
  • Focused on Plugin initial setup, all the module setup and Dashboard Sharing test.

LGTM. 👍

@kuasha420 kuasha420 removed their assignment Feb 26, 2023
@nfmohit nfmohit self-assigned this Feb 26, 2023
@wpdarren wpdarren self-assigned this Feb 26, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Feb 27, 2023

QA Update: ⚠️

I am coming across an issue with the tour tooltips that appear to be a regression because I am unable to recreate on 1.94.0.

For the new dashboard navigation tour tooltip when a user updates Site Kit from a version older than 1.25.0. On the main branch as you go through the steps, on the last tooltip, a fatal error appears.

I am wondering if it is related to the GA4 Reporting work we’re doing because the final step is the Search traffic widget on the dashboard. Just dashboardSharing and ga4ActivationBanner feature flags were enabled, but the issue still arises when they're disabled. You can see it in action on the screencast:

tour-1.mp4

Here's a screenshot of the error messages:

image

@jimmymadon jimmymadon self-assigned this Feb 27, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented Feb 27, 2023

QA Update ⚠️

@wpdarren I'm able to reproduce mentioned issue on 1.95.0.

  • Went through QA check list.
  • Tested using PHP version 7.4, 8.1 and 8.2.
  • Tested site for zero and gathering data state.
  • Tested GA4 activation banner set up.
  • Tested Dashboard sharing functionality.

@mohitwp mohitwp removed their assignment Feb 27, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Feb 27, 2023

QA Update: ⚠️

In AdSense settings, when you click on the See full details in AdSense link you redirected to a 404.

I get the same issue on a few different test sites. This wasn't an issue when I tested 1.94.0.

The requested URL /adsense/start?source=site-kit&url=https%3A%2F%2Ftheremotehive.com&pli=1 was not found on this server. That’s all we know.

When I change to the latest release the issue still exists, so the issue is on Google side, not the plugin.

The 404 status suggests that the URL has changed permanently, I wonder if we should investigate and fix in this release?

I am unsure when the URL was changed but it might cause support tickets.

settings.mp4

@wpdarren
Copy link
Collaborator

wpdarren commented Feb 27, 2023

QA Update: ✅

Observed two issues which I reported above.

Also discovered a few UI enhancements which are not regressions. I will create tickets for these soon.

Verified:

  • Went through the QA checklist
    • Tested with a site in gathering and zero data states
    • Tested with a site with real data
    • Tested using PHP version 7.4
  • Tested GA4 notification banner
  • Tested Dashboard Sharing

@techanvil
Copy link
Collaborator

QA ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Performed some ad-hoc testing.

Found no issues beyond those that have already been raised. I have raised a PR to fix this bug that @wpdarren spotted.

@techanvil techanvil removed their assignment Feb 27, 2023
@tofumatt tofumatt self-assigned this Feb 27, 2023
@tofumatt
Copy link
Collaborator

QA ✅

Smoke tested and went through site setup and upgrades without any issues aside from existing ones; I tested before the above PR mentioned by @techanvil was merged but I tested that in the PR and it seemed fine 🙂 .

@tofumatt tofumatt removed their assignment Feb 27, 2023
@nfmohit
Copy link
Collaborator

nfmohit commented Feb 28, 2023

Release Tested ✅

  • Release tested 1.95.0 thoroughly.
  • Set everything up from scratch on a live (InstaWP) site.
  • Didn't spot any unexpected console errors.
  • Verified UI in different device breakpoints.
  • Verified changes I've been involved with.
  • Used our release testing checklist to ensure everything is checked.
  • Smoke tested with available feature flags.
  • I was able to replicate this issue earlier, and have tested again after this PR was merged, which seems to have resolved it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Development

No branches or pull requests

9 participants