-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @material/web
version and GM3 Checkbox
component.
#6696
Comments
IB ✔️ |
Hmm, while working on the IB for #6652 I've noticed we may run into some complications with this issue. Having updated
Anyhow, just thought I'd put a preemptive flag here to raise awareness! |
QA Update:
|
QA Update: ✅Verified:
gm3.mp4 |
Feature Description
The
@material/web
package has published some more pre-release versions since we installed it. We should install the latest version (v1.0.0-pre.3
at the time of writing).We should then update the GM3
Checkbox
component to removing the label hack that adds a click handler to the label so the label can also trigger the checkbox, as this will no longer be necessary since@material/web
now supports form-associated labels for checkboxes, which provide this behaviour as standard.Note, it looks like we should not remove the
aria-label
, as it appears screen readers still need this as they won't pick up the label text via the form-associated label (see HTML Labels in the one-pager document). Besides which, adding thisaria-label
is not in the same hackish territory as the click handler and it's arguably adding some useful semantics anyway.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
@material/web
should be updated to the latest version.Checkbox
component should have its label click handler removed, while clicking on the label should still trigger the checkbox.Implementation Brief
@material/web
NPM dependency to the latest version.Checkbox
label click handler.Test Coverage
QA Brief
Checkbox
component to make sure it still looks and behaves as expected. That can be done by testing GM3 checkboxes in Storybook: https://google.github.io/site-kit-wp/storybook/develop/?path=/story/components-material-3-checkbox--checkboxesCheckbox
) #5190 for more details.Changelog entry
The text was updated successfully, but these errors were encountered: