Update @material/web version and GM3 Checkbox component.
#7108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The @material/web md-checkbox will now automatically get role="presentation" applied.
Note that the tests for clicking on the label have been disabled due to incompatibilities between the latest @material/web version and JSDom.
techanvil
commented
May 30, 2023
| new Event( 'change', { bubbles: true, cancelable: true } ) | ||
| ); | ||
| }; | ||
| const labelID = `${ id }-label`; |
There was a problem hiding this comment.
Noting that the element-internals-polyfill package (introduced in this PR to to polyfill attachInternals() for JSDom) sets aria-labelledby reminded me that we should do that ourselves for non-polyfilled production scenarios.
|
Build files for abb85cc have been deleted. |
|
Size Change: +274 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
techanvil
commented
May 30, 2023
| @@ -115,8 +102,8 @@ export default function Checkbox( { | |||
| <md-checkbox | |||
| id={ id } | |||
| ref={ ref } | |||
| role="checkbox" | |||
There was a problem hiding this comment.
The md-checkbox now has its role automatically set to "production", overriding what we specify here, so there's no point setting it.
techanvil
commented
May 30, 2023
| ).toBe( 'Complex Label With 5 Sub Children' ); | ||
| } ); | ||
|
|
||
| it( 'should attach the onKeyDown handler when present', () => { | ||
| const onKeyDown = jest.fn(); | ||
|
|
||
| const { getByRole } = render( | ||
| const { getByLabelText } = render( |
There was a problem hiding this comment.
Use getByLabelText() rather than getByRole() to reflect the fact we're no longer setting the role directly.
techanvil
commented
May 30, 2023
| @@ -34,6 +38,7 @@ module.exports = { | |||
| '<rootDir>/node_modules', | |||
| '<rootDir>/build', | |||
| ], | |||
| modulePathIgnorePatterns: [ '<rootDir>/.vscode' ], | |||
There was a problem hiding this comment.
When using the GitHub Copilot plugin, it updates local VSCode settings with regularity when switching back to VSCode, causing watched tests to re-run without the source files changing. Adding this path to modulePathIgnorePatterns prevents this from happening.
tofumatt
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
@material/webversion and GM3Checkboxcomponent. #6696Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist