-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The UA property dropdown is no longer auto-selecting when UA is enabled #6921
Comments
Just a note that this was intentionally done initially as a UA property was being unconditionally auto-selected even though the user didn't opt-in to enable UA, as reported in #6820. This was added as a part of the PR (#6817) for #6744 (commit). A good enhancement here could be auto-selecting a UA property only when the |
Thanks for the added context, @nfmohit. We'll need to figure out what the UX should be here - your suggestion sounds good to me. |
IB ✅ |
Bug/#6921 - Auto-select matched property for the account
QA Update ✅
Recording.331.mp4 |
LGTM 👍 |
Bug Description
As reported by @techanvil in Bug Bash:
The UA property dropdown has stopped auto-selecting a property when UA is enabled in Settings.
This is both when the "Enable Universal Analytics" toggle is first enabled, and when changing to a new Account with the toggle already enabled.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/js/modules/analytics/components/common/EnableUniversalAnalytics.js
file:onChange
callback to find the matching property using thefindMatchedProperty
action if theenableUA
value becomes true and current propertyID and profileID are empty. If the action returns a property, select it using theselectProperty
action.PropertySelect
andProfileSelect
while looking for a matched property.Test Coverage
QA Brief
ga4Reporting
feature flag is enabled.Changelog entry
The text was updated successfully, but these errors were encountered: