Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UA property dropdown is no longer auto-selecting when UA is enabled #6921

Closed
mxbclang opened this issue Apr 19, 2023 · 5 comments
Closed
Labels
Exp: SP Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working

Comments

@mxbclang
Copy link

mxbclang commented Apr 19, 2023

Bug Description

As reported by @techanvil in Bug Bash:

The UA property dropdown has stopped auto-selecting a property when UA is enabled in Settings.

This is both when the "Enable Universal Analytics" toggle is first enabled, and when changing to a new Account with the toggle already enabled.

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When the UA toggle is enabled, if there is a matching property for the site, it should be automatically selected after enabling UA in Analytics Settings.

Implementation Brief

  • In the assets/js/modules/analytics/components/common/EnableUniversalAnalytics.js file:
    • Update the onChange callback to find the matching property using the findMatchedProperty action if the enableUA value becomes true and current propertyID and profileID are empty. If the action returns a property, select it using the selectProperty action.
    • Display small progress bars instead of PropertySelect and ProfileSelect while looking for a matched property.

Test Coverage

  • N/A

QA Brief

  • Ensure the ga4Reporting feature flag is enabled.
  • Verify that when the "Enable Universal Analytics" toggle is enabled, the matched property for the selected account is automatically selected.
  • Confirm this behavior in both the setup and settings edit forms.
  • Note: The account setup URL and the site URL should be the same to auto-select the property for the selected account. If the account is setup using a different URL, the property won't be auto-selected.

Changelog entry

  • Ensure Universal Analytics property is automatically selected when GA4 Reporting is enabled.
@mxbclang mxbclang added Type: Bug Something isn't working P1 Medium priority Module: Analytics Google Analytics module related issues labels Apr 19, 2023
@nfmohit nfmohit assigned nfmohit and unassigned nfmohit Apr 19, 2023
@nfmohit
Copy link
Collaborator

nfmohit commented Apr 19, 2023

Just a note that this was intentionally done initially as a UA property was being unconditionally auto-selected even though the user didn't opt-in to enable UA, as reported in #6820.

This was added as a part of the PR (#6817) for #6744 (commit).

A good enhancement here could be auto-selecting a UA property only when the Enable Universal Analytics toggle is on.

@techanvil
Copy link
Collaborator

Thanks for the added context, @nfmohit. We'll need to figure out what the UX should be here - your suggestion sounds good to me.

@tofumatt
Copy link
Collaborator

IB ✅

@tofumatt tofumatt assigned hussain-t and unassigned tofumatt Apr 27, 2023
@hussain-t hussain-t removed their assignment Apr 28, 2023
@nfmohit nfmohit assigned nfmohit and hussain-t and unassigned nfmohit Apr 28, 2023
hussain-t added a commit that referenced this issue May 8, 2023
@hussain-t hussain-t assigned nfmohit and unassigned hussain-t May 8, 2023
@nfmohit nfmohit assigned hussain-t and unassigned nfmohit May 9, 2023
hussain-t added a commit that referenced this issue May 9, 2023
@hussain-t hussain-t assigned nfmohit and unassigned hussain-t May 9, 2023
@nfmohit nfmohit removed their assignment May 9, 2023
@tofumatt tofumatt self-assigned this May 9, 2023
tofumatt added a commit that referenced this issue May 9, 2023
Bug/#6921 - Auto-select matched property for the account
@tofumatt tofumatt removed their assignment May 9, 2023
@mohitwp mohitwp self-assigned this May 10, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented May 12, 2023

QA Update ✅

  • Tested on dev environment.
  • Tested when 'ga4Reporting' feature flag is enabled.
  • Verified UA property dropdown auto selection under set up as well as under settings.
  • Verified if there is a matching site, then enabling the toggle button auto selects the property.
Recording.331.mp4

@mohitwp mohitwp removed their assignment May 12, 2023
@aaemnnosttv
Copy link
Collaborator

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP Module: Analytics Google Analytics module related issues P1 Medium priority Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants