-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.101.0 #6982
Comments
QA ✅
|
QA Update
|
@wpdarren I just tested this and those are both showing for me on the shared dashboard. The problem in your case is that Search Console isn't shared with your user's role as can be seen in the view only menu |
@aaemnnosttv yes, I just deleted my comment because I realised I was being stupid. 🤣 |
QA Update: ✅Note: I am able to see the console error that Mohit highlighted above. I have completed my release testing:
|
I just opened #7064 as a quick fix for something that I noticed while testing. It's not a regression but something we should include in the release which is a very small change that won't invalidate the rest of the QA done here. |
QA Verified ✅
|
Release Tested ✅
|
QA ✅
Spent a bit more time with this one since it's a big release and we haven't done a release in awhile. Everything looked good for me. 👍🏻 |
QA Verified ✅
|
Release Tested ✅
|
QA: ✔️
LGTM. 👍 |
@aaemnnosttv Just flagging here the issue which I reported above. Wondering if it requires fix or not ? |
@mohitwp thanks for flagging, I'm double-checking this now. |
The issue regarding the console error on the view only dashboard is due to the AdSense status migration checks added in #5628 which haven't been made conditionally on the view-only dashboard. We'll want to address that in a follow-up but it need not block the release since the error does not break anything, and a non-admin shouldn't see that migration notice anyways since they wouldn't be able to action it for the same reason. I'll open an issue to address this, thanks again for flagging 👍 Edit: Opened #7074 |
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: