Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.101.0 #6982

Closed
aaemnnosttv opened this issue Apr 25, 2023 · 15 comments
Closed

Release 1.101.0 #6982

aaemnnosttv opened this issue Apr 25, 2023 · 15 comments
Labels
P0 High priority Type: Task Tasks which do not involve engineering

Comments

@aaemnnosttv
Copy link
Collaborator


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

  • N/A

QA Brief

  • N/A

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added Type: Task Tasks which do not involve engineering P0 High priority labels Apr 25, 2023
@aaemnnosttv aaemnnosttv self-assigned this Apr 25, 2023
@wpdarren wpdarren self-assigned this May 18, 2023
@mohitwp mohitwp self-assigned this May 18, 2023
@jimmymadon jimmymadon self-assigned this May 19, 2023
@hussain-t hussain-t self-assigned this May 19, 2023
@techanvil techanvil self-assigned this May 19, 2023
@techanvil
Copy link
Collaborator

QA ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with, barring those aspects which are specific to GA4 Reporting, as they will be covered in the forthcoming E2E testing and there would not be time to cover them all in this round of release testing.
  • Performed some ad-hoc testing.

@techanvil techanvil removed their assignment May 19, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented May 19, 2023

QA Update ⚠️

  • On view only dashboard if AdSense is shared through Dashboard sharing then I'm getting console error.
    Google Site Kit API Error method:GET datapoint:settings type:modules identifier:adsense error:"Sorry, you are not allowed to do that." On latest environment, I'm not getting this console error.

image

cc @wpdarren

@mohitwp mohitwp removed their assignment May 19, 2023
@aaemnnosttv
Copy link
Collaborator Author

@wpdarren I just tested this and those are both showing for me on the shared dashboard. The problem in your case is that Search Console isn't shared with your user's role as can be seen in the view only menu
image

@wpdarren
Copy link
Collaborator

@aaemnnosttv yes, I just deleted my comment because I realised I was being stupid. 🤣

@wpdarren
Copy link
Collaborator

QA Update: ✅

Note: I am able to see the console error that Mohit highlighted above.

I have completed my release testing:

  • Went through our QA checklist on a site in gathering, zero data state, and real data.
  • Didn't complete any GA4 Reporting testing as this will be picked up next week in our final E2E testing.
  • Completed additional testing around AdSense with legacy and V2.
  • Tested dashboardSharing and ga4ActivationBanner
  • Made sure that GTESupport was still functioning as expected.

@wpdarren wpdarren removed their assignment May 19, 2023
@aaemnnosttv
Copy link
Collaborator Author

I just opened #7064 as a quick fix for something that I noticed while testing. It's not a regression but something we should include in the release which is a very small change that won't invalidate the rest of the QA done here.

@nfmohit nfmohit self-assigned this May 20, 2023
@hussain-t
Copy link
Collaborator

QA Verified ✅

  • Smoke tested.
  • Verified the changes I’ve been involved with.
  • Performed some ad-hoc testing.

@hussain-t hussain-t removed their assignment May 21, 2023
@nfmohit
Copy link
Collaborator

nfmohit commented May 21, 2023

Release Tested ✅

  • Release tested 1.101.0 thoroughly.
  • Set everything up from scratch on a live (InstaWP) site.
  • Didn't spot any unexpected console errors.
  • Verified UI in different device breakpoints.
  • Verified changes I've been involved with.
  • Used our release testing checklist to ensure everything is checked.

@nfmohit nfmohit removed their assignment May 21, 2023
@tofumatt tofumatt self-assigned this May 21, 2023
@tofumatt
Copy link
Collaborator

tofumatt commented May 21, 2023

QA ✅

  • Spent time testing with GA4 Reporting disabled and enabled.
  • Tested GA4 Reporting on mobile viewports.
  • Usual smoke and setup flow tests.

Spent a bit more time with this one since it's a big release and we haven't done a release in awhile.

Everything looked good for me. 👍🏻

@tofumatt tofumatt removed their assignment May 21, 2023
@jimmymadon
Copy link
Collaborator

QA Verified ✅

  • Smoke tested and verified the changes I’ve been involved with.

@jimmymadon jimmymadon removed their assignment May 22, 2023
@kuasha420 kuasha420 self-assigned this May 22, 2023
@10upsimon 10upsimon self-assigned this May 22, 2023
@10upsimon
Copy link
Collaborator

Release Tested ✅

  • Release tested 1.101.0 of the plugin on InstaWP site and configured from a fresh installation
  • Smoke tested admin/settings views
  • Smoke tested frontend/UI, no unexpected errors appeared to be present
  • Very high level verification of changes as obtained via the approved/merged issues of the release
  • Performed testing steps as per release testing check list

@10upsimon 10upsimon removed their assignment May 22, 2023
@kuasha420
Copy link
Contributor

QA: ✔️

  • Went through the release QA testing, set everything up from scratch on a fresh site.
  • Tested with and without gteSupport and dashboardSharing feature flag.
  • Tested the changes I was involved with.

LGTM. 👍

@kuasha420 kuasha420 removed their assignment May 22, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented May 23, 2023

@aaemnnosttv Just flagging here the issue which I reported above. Wondering if it requires fix or not ?

@aaemnnosttv
Copy link
Collaborator Author

@mohitwp thanks for flagging, I'm double-checking this now.

@aaemnnosttv
Copy link
Collaborator Author

aaemnnosttv commented May 23, 2023

The issue regarding the console error on the view only dashboard is due to the AdSense status migration checks added in #5628 which haven't been made conditionally on the view-only dashboard. We'll want to address that in a follow-up but it need not block the release since the error does not break anything, and a non-admin shouldn't see that migration notice anyways since they wouldn't be able to action it for the same reason.

I'll open an issue to address this, thanks again for flagging 👍

Edit: Opened #7074

@aaemnnosttv aaemnnosttv removed their assignment May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Task Tasks which do not involve engineering
Projects
None yet
Development

No branches or pull requests

10 participants