Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined error state when ALL Key Metric Widget Tiles throw an error #7311

Closed
jimmymadon opened this issue Jul 14, 2023 · 3 comments
Closed
Labels
maybelater Reason for closed issues Type: Enhancement Improvement of an existing feature

Comments

@jimmymadon
Copy link
Collaborator

jimmymadon commented Jul 14, 2023

Feature Description

Key Metric widget tiles are much smaller than our usual widgets and hence require new error components to be designed as per the Figma mocks.

This issue was split out from #7149 since point 2 in that issue's AC was making things quite complicated.

This issue (#7311) focuses on the rather complicated and possibly rare error "combined" error state when all widget tiles throw an error:
Screenshot 2023-06-09 at 13 06 57

#7310 focuses on the simpler error state for individual Key Metric widget tiles:
Screenshot 2023-07-11 at 17 59 49


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • If all the Key Metric Widget tiles are throwing an error, then a single larger component should be rendered as per this Figma mock instead of multiple smaller tile errors.
    • Clicking on the "Retry" button should behave like our existing ReportErrorActions component invalidating the resolution of the selectors that threw an error thereby attempting to resolve those selectors again.
    • Clicking on the "Get Help" link should also behave like our existing ReportErrorActions component and use the getErrorTroubleshootingLinkURL selector.
  • Any Key Metric widget tiles implemented already should have this functionality added to them. Tiles implemented after this feature is executed will reuse the components created as part of this issue.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@techanvil
Copy link
Collaborator

techanvil commented Jul 14, 2023

Please note, as this issue needs a bit of further consideration, when discussing this from a UX perspective we should consider these points that @10upsimon raised in his comment on the original issue:

  • I have some concerns around the UX/UI implications of the "all widgets erroring" scenario, it would be quite visually jarring to go form 1, 2 or maybe even 3 rows of key metrics widget components to all of a sudden having a single error component that occupies considerably less UI space, do you think this needs to be raised with UX?

With regard to the point above, It's worth noting that in fact the "multiple rows" scenario will only occur in the tablet and mobile viewports with up to two and four rows accordingly.

  • Given that loading states can be resolved at differing times, this too could be a UX consideration, having multiple widgets enter into individual error states, only to then be replaced with the single one as above.

The implication here is that we won’t be able to individually load widget tiles and would have to effectively wait until all the tiles are loaded before rendering any, if we want to avoid this scenario.

cc @sigal-teller

@mxbclang mxbclang added the P1 Medium priority label Jul 19, 2023
@jimmymadon
Copy link
Collaborator Author

@bethanylang Will run this past @marrrmarrr in our AC sync before closing this out as discussed in our last stand up.

@kuasha420 kuasha420 added the Team Review Issue needs to be reviewed by team for triaging label Aug 7, 2023
@jimmymadon
Copy link
Collaborator Author

Based on the complications and UX considerations pointed in @techanvil 's comment above, we would be sacrificing UX in more frequent use cases than in the rare edge case of all tiles failing to load. So decided to close this issue in our AC sync on 7 Aug 2023.

@jimmymadon jimmymadon removed their assignment Aug 7, 2023
@jimmymadon jimmymadon closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
@aaemnnosttv aaemnnosttv added maybelater Reason for closed issues and removed P1 Medium priority Team Review Issue needs to be reviewed by team for triaging labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maybelater Reason for closed issues Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

5 participants