Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary New badge after setting up KMW #7940

Closed
aaemnnosttv opened this issue Dec 1, 2023 · 4 comments
Closed

Add temporary New badge after setting up KMW #7940

aaemnnosttv opened this issue Dec 1, 2023 · 4 comments
Labels
P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Dec 1, 2023

Feature Description

This is a follow up to #7376 which added the (static) new badge to KMW but was later removed in #6786. As part of restoring this, we also want to make it temporary.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • When first setting up the Key Metrics widget, a "New" badge should be shown in the widget area's header, as in the designs
  • The badge's display should be temporary and the badge should only be visible for two weeks

Implementation Brief

Test Coverage

  • Minimal coverage is fine given the time constraints; this should also be easy to verify in QA

QA Brief

  • If using an existing test site, do a reset first
  • Check that the new badge appears after setting up KMW both ways (tailored metrics + choosing own)
  • To simulate the expiration of time that the badge is shown, use a plugin like Transients Manager to clear all transients
  • While viewing KMW tiles, the new badge can also be toggled on/off temporarily in the browser (not a replacement for the above)

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P0 High priority Type: Enhancement Improvement of an existing feature labels Dec 1, 2023
@aaemnnosttv aaemnnosttv self-assigned this Dec 1, 2023
@aaemnnosttv aaemnnosttv removed their assignment Dec 1, 2023
@kuasha420 kuasha420 assigned kuasha420 and unassigned kuasha420 Dec 4, 2023
@kuasha420
Copy link
Contributor

Noting that, upon discussion with @marrrmarrr we decided to make the time two weeks instead of one for now, and will also factor in number of logins since setup in a follow up enhancement to this.

@wpdarren wpdarren self-assigned this Dec 4, 2023
@wpdarren
Copy link
Collaborator

wpdarren commented Dec 4, 2023

QA update: ❌

@kuasha420 I noticed that when I select metrics and save them, the dashboard loads with the widget and the appropriate tiles, but the badge does not load. When I refresh the dashboard, the badge then appears.

Screencast below.

kmw-badge-ui.mp4

I also want to note, more for @aaemnnosttv to get his opinion, but we don't have the new badge on the widget when only the CTA appears, which feels like an odd user experience. I would expect it to appear.

@wpdarren wpdarren assigned kuasha420 and unassigned wpdarren Dec 4, 2023
@kuasha420 kuasha420 removed their assignment Dec 4, 2023
@aaemnnosttv
Copy link
Collaborator Author

@wpdarren the follow-up which addresses your point above has been merged

@aaemnnosttv aaemnnosttv assigned aaemnnosttv and unassigned wpdarren Dec 4, 2023
@aaemnnosttv
Copy link
Collaborator Author

QA + Approval ✅

Tested this a number of ways, and this looks good to go 🚀

  • Setting up when choosing Tailored metrics
  • Setting up when choosing own metrics
  • New badge is shown right after set up is completed and on subsequent page refreshes
  • Shows as expected in a view-only context (i.e. set up by another user)
  • Disappears after transient expires (set to 2 weeks)

It's worth noting that the New badge does not show on the header of the CTA before the feature is set up, but this is a bit out of scope with the AC as defined and something we can consider as a future enhancement.

Thanks all!

@aaemnnosttv aaemnnosttv removed their assignment Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants