-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add temporary New badge after setting up KMW #7940
Comments
Noting that, upon discussion with @marrrmarrr we decided to make the time two weeks instead of one for now, and will also factor in number of logins since setup in a follow up enhancement to this. |
QA update: ❌@kuasha420 I noticed that when I select metrics and save them, the dashboard loads with the widget and the appropriate tiles, but the badge does not load. When I refresh the dashboard, the badge then appears. Screencast below. kmw-badge-ui.mp4I also want to note, more for @aaemnnosttv to get his opinion, but we don't have the new badge on the widget when only the CTA appears, which feels like an odd user experience. I would expect it to appear. |
@wpdarren the follow-up which addresses your point above has been merged |
QA + Approval ✅Tested this a number of ways, and this looks good to go 🚀
It's worth noting that the New badge does not show on the header of the CTA before the feature is set up, but this is a bit out of scope with the AC as defined and something we can consider as a future enhancement. Thanks all! |
Feature Description
This is a follow up to #7376 which added the (static) new badge to KMW but was later removed in #6786. As part of restoring this, we also want to make it temporary.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Key_Metrics_Setup_Completed_By
value upon successful setup of KMW, set a transient (e.g.googlesitekit_key_metrics_setup_new
) to a booleantrue
, using an expiration ofWEEK_IN_SECONDS
keyMetricsSetupCompletedBy
askeyMetricsSetupCompletedNew
Test Coverage
QA Brief
While viewing KMW tiles, the new badge can also be toggled on/off temporarily in the browser (not a replacement for the above)Changelog entry
The text was updated successfully, but these errors were encountered: