-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Key Metrics New badge for first time setup. #7950
Conversation
Build files for d8680c3 have been deleted. |
Size Change: +62 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kuasha420 – this changes the component a little with respect to the current QAB since the new state is no longer directly tied to the datastore, but I think that's okay for now.
My only concern here was that the initial state could potentially be undefined and then load with a value (making the initial value inaccurate) but that doesn't seem to be the case in my testing.
LGTM 👍
@aaemnnosttv Thanks for confirming. I was also weary of them being |
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist