Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions using deprecated runtimes #8428

Closed
5 tasks
aaemnnosttv opened this issue Mar 25, 2024 · 3 comments
Closed
5 tasks

Update GitHub actions using deprecated runtimes #8428

aaemnnosttv opened this issue Mar 25, 2024 · 3 comments
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Infrastructure Engineering infrastructure & tooling

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Mar 25, 2024

Feature Description

Some GitHub actions that we use have started to raise deprecation warnings.

E.g.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-node@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This is not an exhaustive list, but an example that references several actions that we use across many workflows.

See also #6188


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • All GitHub action workflows should be audited for workflows using deprecated runtimes (this is surfaced in workflow runs as an annotation (example))
  • All actions using deprecated runtimes should be upgraded to a version that is free of deprecations
    • In the absence of an upgrade that satisfies this criteria, steps should be outlined for each instance to be upgraded or replaced in the future and the relevant deadline that this must happen by

Note: this has no effect on the Node runtime used in our jobs (i.e. controlled by nvmrc) it's specific to the runtime used by actions

Implementation Brief

  • Update all usage of actions/checkout@v3/actions/checkout to actions/checkout@v4
  • Update all usage of actions/setup-node@v3/actions/setup-node to actions/setup-node@v4
  • Update google-github-actions/auth@v1 to use google-github-actions/auth@v2. From the changelog for google-github-actions/auth it does not look like there are any obvious breaking changes that would prevent us from upgrading.
  • Update peter-evans/find-comment@v2 to v3
  • Update peter-evans/create-or-update-comment@v2 to v4

Note: the compressed size action (see: https://github.com/google/site-kit-wp/actions/runs/8467166896) uses Node 12 and has no upgrade path, so it won't be updated.

Test Coverage

  • No test updates needed, but check all actions to ensure no deprecation notices appear for Node 16 usage from our actions.

QA Brief

  • No QA needed; CI tests passing is all that's needed. Once merged, this can be moved directly to approval. 🙂

Changelog entry

  • N/A
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Infrastructure Engineering infrastructure & tooling labels Mar 25, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Mar 28, 2024
@eugene-manuilov eugene-manuilov self-assigned this Mar 29, 2024
@eugene-manuilov
Copy link
Collaborator

IB ✔️

@eugene-manuilov eugene-manuilov removed their assignment Mar 29, 2024
@mxbclang mxbclang added Team S Issues for Squad 1 and removed Team S Issues for Squad 1 labels Apr 1, 2024
@eclarke1 eclarke1 added the Team S Issues for Squad 1 label May 29, 2024
@tofumatt tofumatt self-assigned this Jun 3, 2024
@tofumatt tofumatt removed their assignment Jun 10, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Jun 11, 2024
@eugene-manuilov
Copy link
Collaborator

Moved straight to Approval since there is nothing to QA.

@aaemnnosttv
Copy link
Collaborator Author

❌ Approval

There are still a number of instances of actions that need updating as can be seen in the annotations of action runs such as this one https://github.com/google/site-kit-wp/actions/runs/9513898534

image

Please open a follow up issue to address the remaining instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team S Issues for Squad 1 Type: Infrastructure Engineering infrastructure & tooling
Projects
None yet
Development

No branches or pull requests

6 participants