-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub actions using deprecated runtimes #6188
Comments
IB ✔️ |
@tofumatt I don't think #6026 is related to this issue because the version of Node we use (via |
@aaemnnosttv Fair enough—I was a bit concerned that any actions that used Node to then build our code or run our things might experience issues on Node 16 if our package wasn't set up to run with it, but I guess if that does come up we can evaluate. For now I've excluded that bit from the IB. |
QA: ✔️Checked a recent PR and GH actions are running fine (Except the usual VRT failure) |
Feature Description
Similar to #6104, this issue is for upgrading actions that are using deprecated runtimes.
Example notice from a recent run:
As noted above, the warning implicates
actions/checkout@v2
andactions/cache@v2
which are used across many workflows although there could be others. Workflow run logs should be reviewed for each to see if there are any other actions that are using deprecated runtimes.Also note that #6104 already calls for upgrading
actions/cache@v2
.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Given this required auditing all of our actions anyway, it seemed a good opportunity to look through any actions we're using that could be upgraded and upgrading them if possible—also pointing out any blockers to upgrading them.
(From my investigation it looks like only
actions/checkout
and possiblyactions/upload-artifact@v1
is using a deprecated runtime.)actions/checkout@v2
toactions/checkout@v3
c2corg/browserslist-update-action@v1
toc2corg/browserslist-update-action@v2
preactjs/compressed-size-action@v1
topreactjs/compressed-size-action@v2
actions/upload-artifact@v1
/actions/upload-artifact@v2
toactions/upload-artifact@v3
actions/download-artifact@v1
/actions/download-artifact@v2
toactions/download-artifact@v3
Many of these updated actions use Node 16, but using a newer version of Node (node
16
) is already an issue (#6026). @aaemnnosttv pointed out it shouldn't need to be upgraded for our code, but if the actions run into issues with Node versions this issue might depend on #6026. For now they can be treated as separate issues.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: