Simplify in-progress state when submitting User Input answers. #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +565 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
hussain-t
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks, @sashadoes. The changes LGTM. However, I did a bit of testing and found the What are your top goals for this site? section’s checkboxes are editable (not disabled). Ideally, I think the Edit link should be disabled, and we shouldn’t let the users edit while submitting. WDYT?
Screen.Recording.2023-01-11.at.4.08.51.PM.mov
cc: @aaemnnosttv
|
@hussain-t thanks for the review and feedback. I made an update. |
hussain-t
approved these changes
Jan 11, 2023
eugene-manuilov
requested changes
Jan 12, 2023
There was a problem hiding this comment.
Thanks, @sashadoes. Mostly looks good to me. Added two comments for you. Please, take a look.
| > | ||
| { __( 'Save', 'google-site-kit' ) } | ||
| { isScreenLoading && ( | ||
| <Spinner isSaving={ isScreenLoading } /> |
There was a problem hiding this comment.
We have the SpinnerButton component for this purposes. Could you please update this component to use it instead?
| @@ -30,7 +35,7 @@ import { CORE_LOCATION } from '../../googlesitekit/datastore/location/constants' | |||
| import Link from '../Link'; | |||
| const { useSelect, useDispatch } = Data; | |||
|
|
|||
| export default function CancelUserInputButton() { | |||
| export default function CancelUserInputButton( { disabled = false } ) { | |||
There was a problem hiding this comment.
The default state for the disabled property is undefined. Let's stick with it:
Suggested change
| export default function CancelUserInputButton( { disabled = false } ) { | |
| export default function CancelUserInputButton( { disabled } ) { |
eugene-manuilov
requested changes
Jan 13, 2023
There was a problem hiding this comment.
Actually, just noticed that this PR has merge conflicts. @sashadoes, could you please resolve all merge conflicts?
eugene-manuilov
deleted the
enhancement/6323-simplify-submitting-user-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist