Upgrade the checkout Github action. #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -4.26 kB (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
aaemnnosttv
reviewed
Dec 19, 2022
There was a problem hiding this comment.
Thanks @jimmymadon – this looks good to me, one question about the browserslist action as I seem to recall we had to use v1 so long as we were using an older node/npm version.
| @@ -59,7 +59,7 @@ jobs: | |||
| git config --global user.name "GitHub Actions" | |||
|
|
|||
| - name: Update Browserslist database and create PR if applicable | |||
| uses: c2corg/browserslist-update-action@v1 | |||
| uses: c2corg/browserslist-update-action@v2 | |||
There was a problem hiding this comment.
@nfmohit can we do this? I seem to recall that we can't.
There was a problem hiding this comment.
That is correct, thank you for spotting, @aaemnnosttv.
@jimmymadon Unfortunately, the v2 of c2corg/browserslist-update-action wouldn't work in our case because it requires a higher Node & NPM version to function. Until that is updated, we will need to stick with v1 for now.
More context here.
nfmohit
requested changes
Dec 20, 2022
There was a problem hiding this comment.
Thank you, @jimmymadon.
Just reflecting on what @aaemnnosttv raised, we need to revert the c2corg/browserslist-update-action to use v1.
| @@ -59,7 +59,7 @@ jobs: | |||
| git config --global user.name "GitHub Actions" | |||
|
|
|||
| - name: Update Browserslist database and create PR if applicable | |||
| uses: c2corg/browserslist-update-action@v1 | |||
| uses: c2corg/browserslist-update-action@v2 | |||
There was a problem hiding this comment.
That is correct, thank you for spotting, @aaemnnosttv.
@jimmymadon Unfortunately, the v2 of c2corg/browserslist-update-action wouldn't work in our case because it requires a higher Node & NPM version to function. Until that is updated, we will need to stick with v1 for now.
More context here.
aaemnnosttv
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist