Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RRM setup CTA copy #9524

Closed
2 tasks
nfmohit opened this issue Oct 17, 2024 · 3 comments
Closed
2 tasks

Update RRM setup CTA copy #9524

nfmohit opened this issue Oct 17, 2024 · 3 comments
Labels
Module: RRM Reader Revenue Manager module related issues P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@nfmohit
Copy link
Collaborator

nfmohit commented Oct 17, 2024

Feature Description

The RRM setup CTA copy should be updated to explicitly mention that "subscriptions" aren't available yet as part of the integration.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The description text of the RRM setup CTA widget should be updated according to the following:

Turn casual visitors into loyal readers and earn more from your content with voluntary contributions, surveys, newsletter sign-ups and reader insight tools. Learn more.

* Support for subscriptions coming soon

Implementation Brief

Note for IB Reviewer: The following IB has already been covered in the PR #9526. If the IB looks good to you, please feel free to review the PR and merge it if that looks good, as we're in a slight time-crunch with this one.


  • In assets/js/modules/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.js:
    • Locate the paragraph tag containing the current CTA copy and replace that with the new text mentioned in the ACs.

Test Coverage

  • Fix any failing tests.
  • Update any failing VRT references.

QA Brief

  • Set up Site Kit and turn on the rrmModule feature flag in the tester plugin.
  • Observe the RRM setup CTA and verify that the description copy has changed according to the ACs.

Changelog entry

  • Update the RRM setup CTA copy to explicitly mention that subscriptions aren't available yet as part of the integration.
@nfmohit nfmohit self-assigned this Oct 17, 2024
@nfmohit nfmohit added P0 High priority Type: Enhancement Improvement of an existing feature Team M Issues for Squad 2 Module: RRM Reader Revenue Manager module related issues labels Oct 17, 2024
@nfmohit nfmohit removed their assignment Oct 17, 2024
@nfmohit nfmohit mentioned this issue Oct 17, 2024
19 tasks
@techanvil techanvil self-assigned this Oct 17, 2024
@techanvil
Copy link
Collaborator

IB ✅

techanvil added a commit that referenced this issue Oct 17, 2024
@techanvil
Copy link
Collaborator

As per the IB notes, I've gone ahead and merged the linked PR directly after reviewing it and allowing the CI tests to pass.

@techanvil techanvil removed their assignment Oct 17, 2024
@wpdarren wpdarren self-assigned this Oct 17, 2024
@wpdarren
Copy link
Collaborator

wpdarren commented Oct 17, 2024

QA Update: ✅

Verified:

The change to copy as per the AC is now appearing on the RRM setup CTA on the dashboard.

Turn casual visitors into loyal readers and earn more from your content with voluntary contributions, surveys, newsletter sign-ups and reader insight tools. Learn more.

  • Support for subscriptions coming soon

I tested this on desktop and mobile viewports to make sure that the change in copy didn't impact styling, layout, etc.

Image

@wpdarren wpdarren removed their assignment Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: RRM Reader Revenue Manager module related issues P0 High priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants