Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "One-tap" toggle to include new copy and "Learn more" link #9643

Closed
1 task
tofumatt opened this issue Nov 8, 2024 · 3 comments
Closed
1 task

Update "One-tap" toggle to include new copy and "Learn more" link #9643

tofumatt opened this issue Nov 8, 2024 · 3 comments
Labels
javascript Pull requests that update Javascript code Module: Sign in with Google Sign in with Google (SiwG) related issues. P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature

Comments

@tofumatt
Copy link
Collaborator

tofumatt commented Nov 8, 2024

Feature Description

The "Enable One-tap" button should be expanded with copy and a "Learn more" link that points to https://developers.google.com/identity/gsi/web/guides/offerings#one_tap


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • In assets/js/modules/sign-in-with-google/components/common/OneTapToggle.js
    • Bellow the Switch component, include <HelperText> component, with persistent prop included
      • Use createInterpolateElement to add text and learn more link from the AC. Link component should have external prop included
      • The new content should match Figma design referenced in the AC
    • If additional spacing tweaks are needed, you can apply additional class on .googlesitekit-settings-module__fields-group wrapper and target the p child in assets/sass/components/sign-in-with-google/_googlesitekit-sign-in-with-google-settings-module.scss

Test Coverage

  • VRTs may need updating; no other tests required.

QA Brief

  • Setup Site Kit with signInWithGoogleModule feature flag enabled
  • Setup Sign in with Google module, and go to connected modules and edit Sign in with Google settings
  • Verify that learn more link and helper text are added and match Figma design referenced in AC

Changelog entry

  • Add info to the "One-tap" option in Sign in with Google settings.
@tofumatt tofumatt added javascript Pull requests that update Javascript code Module: Sign in with Google Sign in with Google (SiwG) related issues. Next Up Issues to prioritize for definition P1 Medium priority Team S Issues for Squad 1 labels Nov 8, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Nov 8, 2024
@eugene-manuilov eugene-manuilov self-assigned this Nov 12, 2024
@eugene-manuilov
Copy link
Collaborator

@tofumatt let's point exactly where those changes should be made and what we need to use to add that learn more link.

@eugene-manuilov
Copy link
Collaborator

IB ✔

@eugene-manuilov eugene-manuilov removed their assignment Nov 13, 2024
@zutigrm zutigrm self-assigned this Nov 13, 2024
@binnieshah binnieshah removed the Next Up Issues to prioritize for definition label Nov 13, 2024
@zutigrm zutigrm added the Type: Enhancement Improvement of an existing feature label Nov 13, 2024
@zutigrm zutigrm removed their assignment Nov 14, 2024
@tofumatt tofumatt assigned tofumatt and unassigned tofumatt Nov 14, 2024
@wpdarren wpdarren self-assigned this Nov 22, 2024
@wpdarren
Copy link
Collaborator

QA Update: ✅

  • Text under the "Enable One-tap" toggle in Sign in with Google reads: One Tap allows users to sign in or sign up with one click offering smooth user entry points without redirecting to a dedicated sign in and sign up page. Learn more
  • The Learn more link points to https://developers.google.com/identity/gsi/web/guides/offerings#one_tap
  • The format of the text + Learn more link follows the Figma example.

Image

@wpdarren wpdarren removed their assignment Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code Module: Sign in with Google Sign in with Google (SiwG) related issues. P1 Medium priority Team S Issues for Squad 1 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

6 participants