Enhancement/9643 one tap copy #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 201d54c have been deleted. |
|
Size Change: +438 B (+0.02%) Total Size: 1.88 MB
ℹ️ View Unchanged
|
|
Note: 3 KMW VRT updated are not related to this change, but seems to be originating from develop merged previously from other PR, I fixed it here |
tofumatt
previously requested changes
Nov 14, 2024
Comment on lines
50
to
121
| { isSmallScreen ? ( | ||
| <Grid> | ||
| <Row> | ||
| <Cell size={ 8 }> | ||
| <Grid> | ||
| <Row> | ||
| <Cell size={ 12 }> | ||
| <ClientIDTextField /> | ||
| </Cell> | ||
| </Row> | ||
| <Row> | ||
| <Cell size={ 4 }> | ||
| <ButtonTextSelect /> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <ButtonThemeSelect /> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <ButtonShapeSelect /> | ||
| </Cell> | ||
| </Row> | ||
| <Row> | ||
| <Cell size={ 12 }> | ||
| <OneTapToggle /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <Preview /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| ) : ( | ||
| <Grid> | ||
| <Row> | ||
| <Cell size={ 8 }> | ||
| <Grid className="googlesitekit-sign-in-with-google-settings-fields__stretch-form"> | ||
| <Row> | ||
| <Cell size={ 12 }> | ||
| <ClientIDTextField /> | ||
| </Cell> | ||
| </Row> | ||
| <Row> | ||
| <Cell size={ 4 }> | ||
| <ButtonTextSelect /> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <ButtonThemeSelect /> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <ButtonShapeSelect /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </Cell> | ||
| <Cell | ||
| size={ 4 } | ||
| className="googlesitekit-sign-in-with-google-settings-fields__button-preview" | ||
| > | ||
| <Row> | ||
| <Cell size={ 12 }> | ||
| <OneTapToggle /> | ||
| <Preview /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </Cell> | ||
| <Cell size={ 4 }> | ||
| <Preview /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| </Cell> | ||
| <Cell size={ 12 }> | ||
| <OneTapToggle /> | ||
| </Cell> | ||
| </Row> | ||
| </Grid> | ||
| ) } |
There was a problem hiding this comment.
Let's not use ternaries for big components like this: they get quite hard-to-follow/place.
I'll make the change here, but just a note going forward 🙂
There was a problem hiding this comment.
Also though: this seems like something we can handle with CSS, this seems a bit complicated/has a lot of duplication. Let's find a CSS-only approach. 🤔
There was a problem hiding this comment.
What was the reason for this component split based on viewport size? I removed it and it worked just fine with the "large" viewport code.
There was a problem hiding this comment.
The order of the elements within the grid, in new layout is showing well for desktop, but layout change was needed to re-order one tap toggle on mobile and tablet, so they are above the preview box
tofumatt
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
There were a lot of details on the edit form that do not match with the Figma design, so I polished it here, together with learn more change, to avoid delaying SiWG epic, since we have bug bash coming in few days
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist