-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Beta" Badge to First-Party Mode Toggle #9650
Comments
AC ✅ |
Hi @ankitrox, thanks for drafting this IB. However, I think it should take a slightly different approach. We don't tend to interpolate badges into translated strings like that and in fact there's an existing component with a badge next to a switch and it simply renders it after the switch: site-kit-wp/assets/js/modules/adsense/components/common/UseSnippetSwitch.js Lines 82 to 92 in 3fe82ad
I'd suggest we take the same approach here. |
Thank you @techanvil . I updated the IB to simply add the |
Thanks @ankitrox! IB ✅ |
QA Update: ✅Verified: We're unable to test this on a site right now so as per the QAB, I checked Storybook.
I compared the beta badge for SiWG and checked that the font size, style and dimensions were the same. |
Feature Description
Add a "Beta" badge next to the First-party mode toggle label to indicate the feature is in beta.
For details, refer to the Design Doc and the Figma design.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
FirstPartyModeToggle
component inassets/js/components/first-party-mode/
Badge
component from/assets/js/components
.Badge
component besideSwitch
component withlabel
prop passed asBeta
and className asgooglesitekit-beta-badge
.assets/sass/components/first-party-mode/_googlesitekit-first-party-mode.scss
Test Coverage
FirstPartyModeToggle
component.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: