-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display First-Party Mode Status in Site Health #9667
Comments
AC ✅ |
Thanks @benbowler, good shout. I've amended the AC accordingly and removed this note from the IB. IB ✅ |
Hi @benbowler, FYI, we don't have to alter the // Set `isEnabled` locally:
googlesitekit.data.dispatch( "core/site" ).setFirstPartyModeEnabled( true );
// Persist the settings on the server.
await googlesitekit.data.dispatch( "core/site" ).saveFirstPartyModeSettings(); |
QA Update: ✅Verified:
QA Note: You have to run the code in the QAB on the Site Kit settings screen for this to function correctly. |
Feature Description
Enhance Site Health to show the status of First-party mode, indicating whether it is enabled or disabled.
For details, refer to the Design Doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
firstPartyMode
feature flag is enabled:Implementation Brief
includes/Core/Tags/First_Party_Mode/First_Party_Mode.php
:Module_With_Debug_Fields
trait.get_debug_fields
:$settings = $this->get_settings()->get();
, return the value ofisEnabled
in the following format:Test Coverage
QA Brief
firstPartyMode
feature flag.googlesitekit_first_party_mode
meta key in thewp_options
table.Update:
wp_options
table. Instead we can simply execute the following steps.Changelog entry
firstPartyMode
feature flag is active.The text was updated successfully, but these errors were encountered: