Add First-Party Mode site health and value helpers. #9794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for f82d2af have been deleted. |
benbowler
force-pushed
the
enhancement/9667-fpm-site-health
branch
from
5cbafdc to
fab5ce0
Compare
hussain-t
reviewed
Dec 2, 2024
|
|
||
| return array( | ||
| 'first_party_mode_is_enabled' => array( | ||
| 'label' => __( 'First Party Mode: Enabled', 'google-site-kit' ), |
There was a problem hiding this comment.
@techanvil, should it be First-Party Mode: Enabled with a hyphen?
There was a problem hiding this comment.
Thanks for spotting that @hussain-t, you are quite right, "First-Party" should be hyphenated.
I've amended the AC/IB for this issue, and for #9668 accordingly.
Cc @benbowler
There was a problem hiding this comment.
Thanks @techanvil. Since I'm reviewing the PR I can amend the changes.
cc: @benbowler
There was a problem hiding this comment.
Sounds good, thanks Hussain!
hussain-t
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Nice work, @benbowler! LGTM 👍
Note: I've verified that the CI build failures are unrelated to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
During execution I realised that because First-Party Mode is not a module it's debug fields won't show up. First I updated DebugData before settling on adding the fields in the Analytics and Ads module. The code is in both so that the debug field appears if either module is connected. As they have the same key, only one field shows even if both modules are connected.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist