Update Default Value of isEnabled
Setting to false
for First-Party Mode
#9828
Labels
isEnabled
Setting to false
for First-Party Mode
#9828
Feature Description
Currently, the default value for the
isEnabled
setting of First-Party Mode is set tonull
. When toggling the switch for the first time, if the user turns it "on" and "off" again, the submit CTA text in the Analytics and Ads settings forms remain as "Confirm changes" instead of reverting back to "Save" due to the change being tracked fromnull
to `false'.To resolve this issue and improve the user experience, we need to update the default value of the
isEnabled
setting tofalse
.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
isEnabled
setting in First-Party Mode should be updated fromnull
tofalse
.Implementation Brief
In
includes/Core/Tags/First_Party_Mode/First_Party_Mode_Settings.php
:First_Party_Mode_Settings::get_default
method.isEnabled
setting fromnull
tofalse
.In
assets/js/googlesitekit/datastore/site/first-party-mode.js
:@return
directives in selectors to reflect the above change.Test Coverage
First_Party_Mode_SettingsTest
PHP unit test to assert that the default value for theisEnabled
setting isfalse
.QA Brief
isEnabled
setting in First-Party Mode is updated tofalse
. This can be done during the code review process.Changelog entry
isEnabled
setting tofalse
.The text was updated successfully, but these errors were encountered: