-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RRM publication information upon selection #10055
Update RRM publication information upon selection #10055
Conversation
Build files for 737c5ff have been deleted. |
Size Change: +172 B (+0.01%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @techanvil! This is looking solid. Moving this to MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant work on this, thank you @techanvil! Special props for handling invalid values and multiple values returned from the API!
I've left a couple of small comments for your consideration. Please let me know what you think. Thank you!
assets/js/modules/reader-revenue-manager/datastore/publications.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/datastore/publications.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @techanvil ! ✅
Just a heads-up that I've made a small change to the QAB where the getPaymentOption
selector was mentioned as just paymentOption
, but it's all good now, thanks!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist