Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dedicated reset tool #3095

Merged
merged 8 commits into from
Apr 6, 2021
Merged

Add dedicated reset tool #3095

merged 8 commits into from
Apr 6, 2021

Conversation

aaemnnosttv
Copy link
Collaborator

@aaemnnosttv aaemnnosttv commented Apr 6, 2021 •
edited
Loading

Summary

Addresses issue #2384

Relevant technical choices

  • Redirects to splash page rather than dashboard to avoid an immediate redirect from dashboard to splash due to missing authentication
  • Reset also triggers client side session reset and adds success notification as are done/shown when doing a normal client-side reset

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Apr 6, 2021
eugene-manuilov
eugene-manuilov requested changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM. Found a few things to update before we can merge it.

tests/phpunit/integration/Core/Util/ResetTest.php Outdated Show resolved Hide resolved
includes/Core/Util/Reset.php Outdated Show resolved Hide resolved
includes/Core/Util/Reset.php Show resolved Hide resolved
includes/Core/Admin/Available_Tools.php Outdated Show resolved Hide resolved
eugene-manuilov
eugene-manuilov approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @aaemnnosttv!

felixarntz
felixarntz approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit c85a225 into develop Apr 6, 2021
@felixarntz felixarntz deleted the enhancement/2384-reset-tool branch April 6, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@eugene-manuilov eugene-manuilov eugene-manuilov approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaemnnosttv @eugene-manuilov @felixarntz