Display actual number of users coming from search in refactored "Unique Visitors (from Search)" widget. (3064) #3142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +881 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
eugene-manuilov
requested changes
Apr 15, 2021
There was a problem hiding this comment.
Thanks, @johnPhillips. It looks good to me. The only thing missing is the storybook report options update. Could you please update it to make sure the storybook stories for this widget work correctly?
| @@ -317,7 +317,7 @@ generateAnalyticsWidgetStories( { | |||
|
|
|||
| }, | |||
| ] ), | |||
| Component: DashboardUniqueVisitorsWidget, | |||
| Component: DashboardSearchVisitorsWidget, | |||
There was a problem hiding this comment.
We also need to update report options here to replicate changes in the component.
| @@ -351,7 +351,7 @@ generateAnalyticsWidgetStories( { | |||
|
|
|||
| }, | |||
| ] ), | |||
| Component: DashboardUniqueVisitorsWidget, | |||
| Component: DashboardSearchVisitorsWidget, | |||
There was a problem hiding this comment.
Same here, we need to update report options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #3064
Relevant technical choices
Checklist