Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/3644 remove rest batch infrastructure #3755

Merged
merged 14 commits into from
Jul 29, 2021

Conversation

ivankruchkoff
Copy link
Contributor

@ivankruchkoff ivankruchkoff commented Jul 26, 2021

Summary

Addresses issue #3644

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Jul 26, 2021
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ivankruchkoff. Mostly looks good, but there are a few things that we need to address before we can merge this PR. Please, take a look.

includes/Core/REST_API/REST_Routes.php Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
includes/Modules/Analytics_4.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ivankruchkoff. It looks good to me.

@eugene-manuilov eugene-manuilov merged commit 47b723d into develop Jul 29, 2021
@eugene-manuilov eugene-manuilov deleted the feature/3644-remove-rest-batch-infrastructure branch July 29, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants