Feature/3646 legacy js removal data api

[ivankruchkoff]

Summary

Addresses issue #3646

Relevant technical choices

Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 4.7 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[ivankruchkoff]

@googlebot I consent.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[eugene-manuilov]

Thanks, @ivankruchkoff. This mostly looks good to me. Added three comments for you. Once they are addressed, it will be good to merge.

[tofumatt]

@googlebot I consent.

[eugene-manuilov]

In general, looks good to me, but there are E2E issues and we need to re-remove request interceptions for /v1/data datapoints in the following files:

• tests/e2e/specs/modules/optimize/activation.test.js
• tests/e2e/specs/modules/pagespeed-insights/activation.test.js

[eugene-manuilov]

LGTM