Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update autoloader to make sure it loads only sitekit classes or its d… #3835

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Update autoloader to make sure it loads only sitekit classes or its d… #3835

merged 1 commit into from
Aug 11, 2021

Conversation

eugene-manuilov
Copy link
Collaborator

@eugene-manuilov eugene-manuilov commented Aug 11, 2021 •
edited
Loading

…ependencies.

Summary

Addresses issue #3830

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@eugene-manuilov eugene-manuilov changed the base branch from develop to main August 11, 2021 18:20
felixarntz
felixarntz reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugene-manuilov One question here, other than that good to go.

includes/loader.php Show resolved Hide resolved
@eugene-manuilov eugene-manuilov mentioned this pull request Aug 11, 2021
Closed
felixarntz
felixarntz approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit b16d4da into main Aug 11, 2021
@felixarntz felixarntz deleted the bug/3830-installed-versions-class branch August 11, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eugene-manuilov @felixarntz