Show helper text when supplied to survey component #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +236 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
aaemnnosttv
requested changes
Aug 24, 2021
There was a problem hiding this comment.
Thanks @tofumatt – we don't actually need to change any styles here (as these come from the component). Instead we're just missing a prop 😄
Comment on lines
64
to
66
| .mdc-text-field-helper-text { | ||
| opacity: 1; | ||
| } |
There was a problem hiding this comment.
This fixes the problem but not quite in the right place.
It turns out the helper text is designed to be conditionally shown and likely uses opacity to avoid a layout shift.
All we need to do is pass the persistent prop to HelperText to indicate that the text is to always be shown as the component is made to also support input validation.
You can also see this work on develop by toggling the prop in React devtools.
There was a problem hiding this comment.
Huh, whoops, thanks! 👍🏻
Comment on lines
75
to
79
| helperText={ | ||
| subtitle ? ( | ||
| <HelperText>{ subtitle }</HelperText> | ||
| ) : undefined | ||
| } |
There was a problem hiding this comment.
Suggested change
| helperText={ | |
| subtitle ? ( | |
| <HelperText>{ subtitle }</HelperText> | |
| ) : undefined | |
| } | |
| helperText={ | |
| subtitle ? ( | |
| <HelperText persistent>{ subtitle }</HelperText> | |
| ) : undefined | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #3762.
It turns out we had a subtitle in here but it was being hidden with an odd
opacity: 0rule. This removes it and makes sure theHelperTextcomponent isn't rendered if there isn't asubtitleprop.Checklist