Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update source of subtitle and placeholder for open_text question #3940

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

aaemnnosttv
Copy link
Collaborator

Summary

Addresses issue #3762

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@github-actions
Copy link

Size Change: +9 B (0%)

Total Size: 1.12 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation.********************.js 38.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-adminbar.********************.js 30.7 kB +1 B (0%)
./dist/assets/js/googlesitekit-dashboard-details.********************.js 44.1 kB +1 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 52.1 kB +1 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 23.9 kB +1 B (0%)
./dist/assets/js/googlesitekit-module.********************.js 44.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-settings.********************.js 48.4 kB +1 B (0%)
./dist/assets/js/googlesitekit-user-input.********************.js 45.4 kB +1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 32.7 kB +1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/admin.css 38.5 kB
./dist/assets/css/adminbar.css 7.95 kB
./dist/assets/css/wpdashboard.css 4.55 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-api.********************.js 9.14 kB
./dist/assets/js/googlesitekit-base.********************.js 1.59 kB
./dist/assets/js/googlesitekit-dashboard.********************.js 44.4 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.86 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.3 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.83 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 21 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.7 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 19 kB
./dist/assets/js/googlesitekit-modules-analytics.********************.js 65.6 kB
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 23.4 kB
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.4 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.5 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 30 kB
./dist/assets/js/googlesitekit-modules.********************.js 16.5 kB
./dist/assets/js/googlesitekit-vendor.********************.js 313 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.5 kB
./dist/assets/js/runtime.********************.js 763 B

compressed-size-action

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@aaemnnosttv aaemnnosttv merged commit afb9e3f into main Aug 25, 2021
@aaemnnosttv aaemnnosttv deleted the followup/3762-open-text-question branch August 25, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants