Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show numbers in Saved and Draft of Idea Hub Dashboard when it is… #3968

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

kuasha420
Copy link
Contributor

@kuasha420 kuasha420 commented Aug 31, 2021

… more than 0.

Summary

Addresses issue #3964

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Aug 31, 2021
@github-actions
Copy link

Size Change: +22 B (0%)

Total Size: 1.12 MB

Filename Size Change
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 23.3 kB +22 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/admin.css 38.5 kB
./dist/assets/css/adminbar.css 8 kB
./dist/assets/css/wpdashboard.css 4.58 kB
./dist/assets/js/32.********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-activation.********************.js 38.1 kB
./dist/assets/js/googlesitekit-adminbar.********************.js 30.8 kB
./dist/assets/js/googlesitekit-api.********************.js 9.14 kB
./dist/assets/js/googlesitekit-base.********************.js 1.59 kB
./dist/assets/js/googlesitekit-dashboard-details.********************.js 43.9 kB
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 52 kB
./dist/assets/js/googlesitekit-dashboard.********************.js 44.3 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.86 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.3 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.83 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 21 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 24 kB
./dist/assets/js/googlesitekit-module.********************.js 44 kB
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.7 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 19 kB
./dist/assets/js/googlesitekit-modules-analytics.********************.js 65.6 kB
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.4 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.5 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 30 kB
./dist/assets/js/googlesitekit-modules.********************.js 16.5 kB
./dist/assets/js/googlesitekit-polyfills.********************.js 378 B
./dist/assets/js/googlesitekit-settings.********************.js 48.4 kB
./dist/assets/js/googlesitekit-user-input.********************.js 45.2 kB
./dist/assets/js/googlesitekit-vendor.********************.js 313 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.5 kB
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 32.8 kB
./dist/assets/js/runtime.********************.js 1.19 kB

compressed-size-action

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit 1914c76 into develop Aug 31, 2021
@felixarntz felixarntz deleted the bug/3964-idea-hub-saved-draft-count branch August 31, 2021 18:25
@felixarntz
Copy link
Member

@kuasha420 Small note on workflows: Please make sure to add the issue number that the PR addresses to the PR description in the summary (i.e. "Addresses issue #..."). I've done that here already, but something to keep in mind for the future. 👍

@kuasha420
Copy link
Contributor Author

@felixarntz That's a oopsie boopsie indeed. I'll be more careful in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants