Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open 'create a new goal' cta in new tab. #3988

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

kuasha420
Copy link
Contributor

@kuasha420 kuasha420 commented Sep 3, 2021

Summary

Addresses issue #3683

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Size Change: +179 B (0%)

Total Size: 1.13 MB

Filename Size Change
./dist/assets/js/googlesitekit-adminbar.********************.js 30.6 kB +26 B (0%)
./dist/assets/js/googlesitekit-dashboard-details.********************.js 44.1 kB +25 B (0%)
./dist/assets/js/googlesitekit-dashboard.********************.js 44.2 kB +25 B (0%)
./dist/assets/js/googlesitekit-module.********************.js 44 kB +24 B (0%)
./dist/assets/js/googlesitekit-modules-adsense.********************.js 44.6 kB +23 B (0%)
./dist/assets/js/googlesitekit-modules-analytics.********************.js 65.6 kB +29 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 32.6 kB +27 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/admin.css 38.5 kB
./dist/assets/css/adminbar.css 8 kB
./dist/assets/css/wpdashboard.css 4.58 kB
./dist/assets/js/33.********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-activation.********************.js 37.7 kB
./dist/assets/js/googlesitekit-api.********************.js 9.04 kB
./dist/assets/js/googlesitekit-base.********************.js 1.59 kB
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 51.8 kB
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB
./dist/assets/js/googlesitekit-datastore-forms.********************.js 8.73 kB
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB
./dist/assets/js/googlesitekit-datastore-site.********************.js 13.2 kB
./dist/assets/js/googlesitekit-datastore-ui.********************.js 8.71 kB
./dist/assets/js/googlesitekit-datastore-user.********************.js 20.9 kB
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice.********************.js 2.4 kB
./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js 23.8 kB
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 18.8 kB
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 23.2 kB
./dist/assets/js/googlesitekit-modules-optimize.********************.js 18.3 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 16.3 kB
./dist/assets/js/googlesitekit-modules-search-console.********************.js 28.4 kB
./dist/assets/js/googlesitekit-modules-subscribe-with-google.********************.js 16.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 29.9 kB
./dist/assets/js/googlesitekit-modules.********************.js 16.4 kB
./dist/assets/js/googlesitekit-polyfills.********************.js 378 B
./dist/assets/js/googlesitekit-settings.********************.js 48.6 kB
./dist/assets/js/googlesitekit-user-input.********************.js 44.8 kB
./dist/assets/js/googlesitekit-vendor.********************.js 312 kB
./dist/assets/js/googlesitekit-widgets.********************.js 11.4 kB
./dist/assets/js/runtime.********************.js 1.19 kB

compressed-size-action

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@aaemnnosttv aaemnnosttv merged commit 01e077b into develop Sep 6, 2021
@aaemnnosttv aaemnnosttv deleted the bug/3683-analytics-cta-external branch September 6, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants