Enhancement/4078 content area widgets #4131

eugene-manuilov · 2021-09-27T14:16:14Z

Summary

Addresses issue #4078

Relevant technical choices

Checklist

My code is tested and passes existing unit tests.
My code has an appropriate set of unit tests which all pass.
My code is backward-compatible with WordPress 4.7 and PHP 5.6.
My code follows the WordPress coding standards.
My code has proper inline documentation.
I have added a QA Brief on the issue linked above.
I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

github-actions · 2021-09-27T14:27:03Z

Size Change: -135 B (0%)

Total Size: 1.15 MB

Filename	Size	Change
`./dist/assets/js/googlesitekit-activation.********************.js`	39.4 kB	+10 B (0%)
`./dist/assets/js/googlesitekit-adminbar.********************.js`	31.6 kB	-2 B (0%)
`./dist/assets/js/googlesitekit-api.********************.js`	9.04 kB	-2 B (0%)
`./dist/assets/js/googlesitekit-dashboard-details.********************.js`	46.2 kB	-6 B (0%)
`./dist/assets/js/googlesitekit-dashboard-splash.********************.js`	54.1 kB	-2 B (0%)
`./dist/assets/js/googlesitekit-dashboard.********************.js`	46.4 kB	-4 B (0%)
`./dist/assets/js/googlesitekit-datastore-forms.********************.js`	8.75 kB	-3 B (0%)
`./dist/assets/js/googlesitekit-datastore-location.********************.js`	2.02 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-datastore-site.********************.js`	13.1 kB	-13 B (0%)
`./dist/assets/js/googlesitekit-datastore-ui.********************.js`	8.7 kB	-3 B (0%)
`./dist/assets/js/googlesitekit-datastore-user.********************.js`	21 kB	-30 B (0%)
`./dist/assets/js/googlesitekit-idea-hub-post-list.********************.js`	24 kB	-3 B (0%)
`./dist/assets/js/googlesitekit-module.********************.js`	45.3 kB	-6 B (0%)
`./dist/assets/js/googlesitekit-modules-adsense.********************.js`	45.3 kB	+6 B (0%)
`./dist/assets/js/googlesitekit-modules-analytics-4.********************.js`	18.9 kB	-5 B (0%)
`./dist/assets/js/googlesitekit-modules-analytics.********************.js`	67.6 kB	+113 B (0%)
`./dist/assets/js/googlesitekit-modules-idea-hub.********************.js`	24.7 kB	-149 B (-1%)
`./dist/assets/js/googlesitekit-modules-optimize.********************.js`	18.3 kB	-8 B (0%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js`	16.9 kB	+3 B (0%)
`./dist/assets/js/googlesitekit-modules-search-console.********************.js`	28.9 kB	-51 B (0%)
`./dist/assets/js/googlesitekit-modules-subscribe-with-google.********************.js`	16.4 kB	+2 B (0%)
`./dist/assets/js/googlesitekit-modules-tagmanager.********************.js`	29.8 kB	+5 B (0%)
`./dist/assets/js/googlesitekit-modules.********************.js`	16.5 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-settings.********************.js`	50 kB	+2 B (0%)
`./dist/assets/js/googlesitekit-user-input.********************.js`	46.3 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-vendor.********************.js`	312 kB	+17 B (0%)
`./dist/assets/js/googlesitekit-widgets.********************.js`	12.7 kB	+2 B (0%)
`./dist/assets/js/googlesitekit-wp-dashboard.********************.js`	33.9 kB	-5 B (0%)

ℹ️ View Unchanged

Filename	Size
`./dist/assets/css/googlesitekit-admin-css.********************.css`	38.6 kB
`./dist/assets/css/googlesitekit-adminbar-css.********************.css`	8 kB
`./dist/assets/css/googlesitekit-wp-dashboard-css.********************.css`	4.58 kB
`./dist/assets/js/33.********************.js`	3.12 kB
`./dist/assets/js/analytics-advanced-tracking.js`	769 B
`./dist/assets/js/googlesitekit-base.********************.js`	1.58 kB
`./dist/assets/js/googlesitekit-data.********************.js`	1.65 kB
`./dist/assets/js/googlesitekit-i18n.js`	3.92 kB
`./dist/assets/js/googlesitekit-idea-hub-notice.********************.js`	2.4 kB
`./dist/assets/js/googlesitekit-polyfills.********************.js`	378 B
`./dist/assets/js/runtime.********************.js`	1.19 kB

_{compressed-size-action}

…ontent-area-widgets.

johnPhillips · 2021-09-28T17:03:13Z

assets/js/modules/analytics/index.js

@@ -118,11 +119,11 @@ export const registerWidgets = ( widgets ) => {
 		'analyticsPopularPages',
 		{
 			Component: DashboardPopularPagesWidget,
-			width: widgets.WIDGET_WIDTHS.HALF,
+			width: [ widgets.WIDGET_WIDTHS.HALF, widgets.WIDGET_WIDTHS.FULL ],


@eugene-manuilov I was wondering: will this mean that this widget could start appearing full width on the current dashboard and cause some regressions?
If so, maybe we should use the feature flag to conditionally apply them?
Let me know what you think.

Technically, it could appear full width on the current dashboard, but it will happen only if there are no other widgets fit into that row. So, I don't think we need to use the feature flag here.

…f a new GA4 property needs to be created.

…ontent-area-widgets.

google-cla · 2021-09-29T15:09:29Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-08T21:02:58Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tofumatt

Looks good. I fixed the merge conflict introduced with the conditional registration based on the unifiedDashboard feature flag.

google-cla · 2021-10-08T21:22:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

tofumatt · 2021-10-08T21:22:42Z

@googlebot I consent.

google-cla · 2021-10-08T21:23:11Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

eugene-manuilov added 4 commits September 27, 2021 17:10

Add required areas.

ebfec7f

Update the DashboardPopularKeywordsWidget widget.

371e420

Update the DashboardIdeasWidget widget.

af7076a

Update the DashboardPopularPagesWidget widget.

542f527

google-cla bot added the cla: yes label Sep 27, 2021

Add the correct width for the DashboardPopularPagesWidget widget.

df4f0f5

Merge remote-tracking branch 'origin/develop' into enhancement/4078-c…

1a80100

…ontent-area-widgets.

johnPhillips reviewed Sep 28, 2021

View reviewed changes

aaemnnosttv and others added 12 commits September 29, 2021 18:07

Restore base path in CSS output filename.

9d9e9ef

Update setup form to check scopes before submitting the form.

8536185

Fix ga4 issues.

85b5442

Fix missing dialog issue.

cf2888a

Revert UA property and profile checks.

aaee6f4

Update error title.

13bb60c

Rework UA/GA4 settings to save GA4 settings before UA settings only i…

0f2a20f

…f a new GA4 property needs to be created.

Revert whitespace changes.

f2a37b6

Scaffold out DashboardMainApp and DashboardEntityApp.

602d41d

Remove debug statement.

1e85272

Remove folder structure for Dashboard apps (CR feedback).

283f687

Merge remote-tracking branch 'origin/develop' into enhancement/4078-c…

5b11db3

…ontent-area-widgets.

google-cla bot added cla: no and removed cla: yes labels Sep 29, 2021

tofumatt added 2 commits October 8, 2021 12:56

Merge branch 'develop' into enhancement/4078-content-area-widgets.

5e09845

Fix widget registration behind feature flags.

1bcc35d

Restore removed module from merge.

5a8270f

tofumatt approved these changes Oct 8, 2021

View reviewed changes

tofumatt merged commit 5af40a4 into develop Oct 8, 2021

tofumatt deleted the enhancement/4078-content-area-widgets branch October 8, 2021 21:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancement/4078 content area widgets #4131

Enhancement/4078 content area widgets #4131

eugene-manuilov commented Sep 27, 2021 •

edited

Loading

github-actions bot commented Sep 27, 2021 •

edited

Loading

johnPhillips Sep 28, 2021

eugene-manuilov Sep 29, 2021

google-cla bot commented Sep 29, 2021

google-cla bot commented Oct 8, 2021

tofumatt left a comment

google-cla bot commented Oct 8, 2021

tofumatt commented Oct 8, 2021

google-cla bot commented Oct 8, 2021

Enhancement/4078 content area widgets #4131

Enhancement/4078 content area widgets #4131

Conversation

eugene-manuilov commented Sep 27, 2021 • edited Loading

Summary

Relevant technical choices

Checklist

github-actions bot commented Sep 27, 2021 • edited Loading

johnPhillips Sep 28, 2021

Choose a reason for hiding this comment

eugene-manuilov Sep 29, 2021

Choose a reason for hiding this comment

google-cla bot commented Sep 29, 2021

google-cla bot commented Oct 8, 2021

tofumatt left a comment

Choose a reason for hiding this comment

google-cla bot commented Oct 8, 2021

tofumatt commented Oct 8, 2021

google-cla bot commented Oct 8, 2021

eugene-manuilov commented Sep 27, 2021 •

edited

Loading

github-actions bot commented Sep 27, 2021 •

edited

Loading