Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels, spacing, and deactivation #4281

Merged
merged 4 commits into from
Oct 27, 2021

Conversation

ChrisAntaki
Copy link
Contributor

@ChrisAntaki ChrisAntaki commented Oct 26, 2021

Summary

Addresses issue #4230

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label Oct 26, 2021
@ChrisAntaki ChrisAntaki marked this pull request as ready for review October 26, 2021 21:28
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisAntaki Mostly good to go, just two minor comments.

…ttingsView.js

Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@github-actions
Copy link

Size Change: -10 B (0%)

Total Size: 1.17 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 39.5 kB -1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 31.7 kB +3 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.09 kB -1 B (0%)
./dist/assets/js/googlesitekit-base-********************.js 1.58 kB +1 B (0%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js 46.4 kB -3 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js 46.6 kB -1 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 54.2 kB -1 B (0%)
./dist/assets/js/googlesitekit-data-********************.js 1.65 kB +2 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.79 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.02 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 13.2 kB -23 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 8.74 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 21 kB -3 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 24 kB -1 B (0%)
./dist/assets/js/googlesitekit-module-********************.js 45.4 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 16.4 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 61.2 kB -14 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 19 kB -2 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 69.4 kB +9 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 24.5 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js 18.4 kB +2 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 16.9 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 29.3 kB +5 B (0%)
./dist/assets/js/googlesitekit-modules-subscribe-with-google-********************.js 16.8 kB +14 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.2 kB -6 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 50.2 kB -6 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 46.4 kB +3 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 312 kB +11 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 12.8 kB -3 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 34 kB +9 B (0%)
./dist/assets/js/runtime-********************.js 1.19 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.css 38.6 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.css 8 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.css 4.58 kB
./dist/assets/js/33-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 2.4 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B

compressed-size-action

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@felixarntz felixarntz merged commit bca9164 into develop Oct 27, 2021
@felixarntz felixarntz deleted the bug/4230-fix-labels-spacing-and-deactivation branch October 27, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants