Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4146 entity context component #4384

Merged
merged 15 commits into from
Nov 25, 2021

Conversation

ivankruchkoff
Copy link
Contributor

@ivankruchkoff ivankruchkoff commented Nov 20, 2021

Summary

Addresses issue #4146

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@ivankruchkoff ivankruchkoff marked this pull request as ready for review November 23, 2021 15:49
@github-actions
Copy link

github-actions bot commented Nov 25, 2021

Size Change: +5.13 kB (0%)

Total Size: 1.22 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.css 40.5 kB +255 B (+1%)
./dist/assets/js/googlesitekit-activation-********************.js 38.6 kB -19 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 31.9 kB +23 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.17 kB +2 B (0%)
./dist/assets/js/googlesitekit-base-********************.js 1.59 kB -1 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js 50.4 kB +416 B (+1%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js 50.8 kB +1.8 kB (+4%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js 66.1 kB +461 B (+1%)
./dist/assets/js/googlesitekit-data-********************.js 1.65 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.89 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.03 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 14.4 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 8.97 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 21.1 kB -1 B (0%)
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js 2.41 kB +2 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js 24.4 kB +25 B (0%)
./dist/assets/js/googlesitekit-module-********************.js 46.2 kB +518 B (+1%)
./dist/assets/js/googlesitekit-modules-********************.js 16.8 kB +23 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 62.3 kB +244 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 71.7 kB +100 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js 25.1 kB +23 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js 18.9 kB +36 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 17 kB -5 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 36.5 kB +105 B (0%)
./dist/assets/js/googlesitekit-modules-subscribe-with-google-********************.js 17.4 kB +29 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 29.9 kB +114 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js 51.2 kB +466 B (+1%)
./dist/assets/js/googlesitekit-user-input-********************.js 47 kB +471 B (+1%)
./dist/assets/js/googlesitekit-vendor-********************.js 315 kB -11 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 13.5 kB +33 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 34.6 kB +24 B (0%)
./dist/assets/js/runtime-********************.js 1.19 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.css 8.02 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.css 4.59 kB
./dist/assets/js/33-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking.js 769 B
./dist/assets/js/googlesitekit-i18n.js 3.92 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 18.9 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B

compressed-size-action

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a comment I think that's worth adding but then we can 🚢

assets/js/components/EntityHeaderBanner.js Outdated Show resolved Hide resolved
@tofumatt
Copy link
Collaborator

@googlebot I consent.

@tofumatt tofumatt merged commit 5dcbb1e into develop Nov 25, 2021
@tofumatt tofumatt deleted the feature/4146-entity-context-component branch November 25, 2021 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants