Fix loading states when report errors

[aaemnnosttv]

Summary

Addresses issue:

• Some components remain in loading state on error #4542

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 4.7 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Size Change: +6.08 kB (0%)

Total Size: 1.41 MB

Filename	Size	Change
./dist/assets/js/33-********************.js	3.12 kB	-1 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js	37.2 kB	+2 B (0%)
./dist/assets/js/googlesitekit-api-********************.js	9.51 kB	-1 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js	56.4 kB	-2 B (0%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js	54 kB	+1 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js	73.5 kB	+6.03 kB (+9%)	🔍
./dist/assets/js/googlesitekit-data-********************.js	2.09 kB	+1 B (0%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js	9.13 kB	+2 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	14.8 kB	+2 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js	26.6 kB	-3 B (0%)
./dist/assets/js/googlesitekit-module-********************.js	47.5 kB	-5 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js	17.8 kB	-1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	69 kB	-6 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	75 kB	+29 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	19.3 kB	-2 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js	35.3 kB	-1 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	18.9 kB	+3 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	41 kB	+15 B (0%)
./dist/assets/js/googlesitekit-modules-subscribe-with-google-********************.js	17.9 kB	-3 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	30.8 kB	-2 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js	51.4 kB	-2 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js	47.9 kB	-5 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js	323 kB	+8 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61 kB	+16 B (0%)
./dist/assets/js/runtime-********************.js	1.22 kB	-1 B (0%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	44.3 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.3 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	6.53 kB
./dist/assets/js/32-********************.js	51.9 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-activation-********************.js	33.7 kB
./dist/assets/js/googlesitekit-base-********************.js	1.58 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.09 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.22 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js	20.9 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js	45.1 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js	19.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	379 B
./dist/assets/js/googlesitekit-widgets-********************.js	19.4 kB

_{compressed-size-action}

[aaemnnosttv]

@kuasha420 looks like Storybook is still broken here according to the check

[aaemnnosttv]

Thanks @kuasha420 – this is looking good, just a few comments left to resolve; almost there I think 👍 Let me know if you have any other questions.

[aaemnnosttv]

Thanks @kuasha420 – this looks good, just a few final tweaks to get this over the line such as applying the changes to the tests from the last review consistently and one comment about an intercepted request that I think we want to keep.

I just pushed a few changes that should address these last few things.

[aaemnnosttv]

Confirmed that these changes fix the problem testing with permissions errors with Analytics and SC.

[aaemnnosttv]

@kuasha420 I can't approve this PR because it's my own 😄

Can you take a quick look over my changes and approve if they look good to you?

[kuasha420]

Thank you @aaemnnosttv for all the help with this one! Looks much cleaner now. Nice. 👍

[tofumatt]

Looks good to me as well; moving to QA 👍🏻