Enhance/4819 auth dependent components #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +866 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
tofumatt
requested changes
Apr 12, 2022
| confirmIfSkipModal(); | ||
| }, [ onConfirm, permissionsError ] ); | ||
|
|
||
| if ( ! permissionsError ) { |
There was a problem hiding this comment.
It looks like this can potentially return undefined, which I was assuming is from it resolving and returning undefined during that, but it appears that actually isn't the case… it's either null or an error.
But the docs say it can return undefined:
site-kit-wp/assets/js/googlesitekit/datastore/user/permissions.js
Lines 147 to 159 in d3aed2e
This isn't related to your change, but we should update the JSDoc for getPermissionScopeError so it doesn't trip anyone else up. Looks like it should be @return {(Object|undefined)} not @return {(Object|null)}
There was a problem hiding this comment.
Worse: I think it was me who wrong that JSDoc. Shame! 😆
tofumatt
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
I had to divert a bit away from the IB to make sure
PermissionModaldoesn't render for non authenticated users. As we can't really use selectors in theRootcomponent, I created a Inner Component and extracted everything from thePermissionModalto the new one. That way we can check the user authentication status inside the now mostly empty and wrapperPermissionMolaland return inner component or null accordingly. See the comments on the original issue for discussion and thanks @aaemnnosttv for the suggestion!PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist