Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function and replace logic #5084

Merged
merged 4 commits into from
Apr 15, 2022
Merged

add function and replace logic #5084

merged 4 commits into from
Apr 15, 2022

Conversation

sancodes
Copy link
Contributor

@sancodes sancodes commented Apr 13, 2022

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@sancodes
Copy link
Contributor Author

sancodes commented Apr 13, 2022

@felixarntz I think I'm struggling with the concepts here, but I made some change there. Can you help me review if the code I wrote matches to your guide. Thank you.
I'm willing to fix it, for any errors.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sancodes Thanks for the PR! At a high level the logic looks right, but there are a couple things that need to be fixed.

Most importantly, check for valid PHP and following the WordPress PHP coding standards.

includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
@sancodes
Copy link
Contributor Author

@felixarntz Sorry if the issue that I've fixed is still wrong. But I read your suggestions and tried recreating it. Can you help me review. I'm willing to fix if there's any issue. Thank you.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sancodes Left a few remaining suggestions.

includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
@sancodes
Copy link
Contributor Author

@felixarntz Is it looking good now? If not I'm willing to fix the mistakes.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things need to be fixed here.

includes/Modules/AdSense.php Outdated Show resolved Hide resolved
includes/Modules/AdSense.php Outdated Show resolved Hide resolved
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sancodes I've made the last few tweaks here, this is good to go now. Thanks for your contribution!

@felixarntz felixarntz merged commit 2f361c7 into google:develop Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants