-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Existing Tag Notice for Analytics Settings Page #5136
Merged
felixarntz
merged 3 commits into
feature/existing-tag-simplification
from
enhance/5046-fix-analytics-settings-description
Apr 27, 2022
Merged
Restore Existing Tag Notice for Analytics Settings Page #5136
felixarntz
merged 3 commits into
feature/existing-tag-simplification
from
enhance/5046-fix-analytics-settings-description
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuasha420
changed the title
Enhance/5046 fix analytics settings description
Restore Existing Tag Notice for Analytics Settings Page
Apr 26, 2022
kuasha420
changed the base branch from
develop
to
feature/existing-tag-simplification
April 26, 2022 18:48
Size Change: +862 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
…fix-analytics-settings-description.
felixarntz
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuasha420 Great, this looks solid for now, until we can iterate in a separate follow-up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist