-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Existing Tag related messages to Settings Snippet Toggles #5150
Move Existing Tag related messages to Settings Snippet Toggles #5150
Conversation
Size Change: -1.43 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kuasha420. Almost looks good to me. Added a few comments. Please, take a look.
assets/js/modules/tagmanager/components/common/FormInstructions.js
Outdated
Show resolved
Hide resolved
assets/js/modules/analytics-4/components/common/SetupUseSnippetSwitch.js
Show resolved
Hide resolved
f160e2b
to
25f16ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @kuasha420.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist