Bug/5183 adsense api account status

[eugene-manuilov]

Summary

Addresses issue:

• Rely strictly on AdSense API to determine account status #5183

Relevant technical choices

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 4.7 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Size Change: +7 B (0%)

Total Size: 1.43 MB

Filename	Size	Change
./dist/assets/js/googlesitekit-dashboard-********************.js	59.3 kB	-1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	71 kB	+14 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	75.1 kB	-2 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js	19.5 kB	+1 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	31.3 kB	-5 B (0%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	44.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.4 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	6.58 kB
./dist/assets/js/32-********************.js	51.9 kB
./dist/assets/js/33-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-activation-********************.js	33.7 kB
./dist/assets/js/googlesitekit-adminbar-********************.js	37.3 kB
./dist/assets/js/googlesitekit-api-********************.js	9.52 kB
./dist/assets/js/googlesitekit-base-********************.js	1.59 kB
./dist/assets/js/googlesitekit-dashboard-details-********************.js	56 kB
./dist/assets/js/googlesitekit-dashboard-splash-********************.js	74.8 kB
./dist/assets/js/googlesitekit-data-********************.js	2.09 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js	9.13 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js	14.8 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.22 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js	21 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js	45.1 kB
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js	26.6 kB
./dist/assets/js/googlesitekit-module-********************.js	49.8 kB
./dist/assets/js/googlesitekit-modules-********************.js	17.8 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	19.3 kB
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js	35.3 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	19 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js	41.3 kB
./dist/assets/js/googlesitekit-modules-subscribe-with-google-********************.js	17.9 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	379 B
./dist/assets/js/googlesitekit-settings-********************.js	53.2 kB
./dist/assets/js/googlesitekit-user-input-********************.js	49.8 kB
./dist/assets/js/googlesitekit-vendor-********************.js	323 kB
./dist/assets/js/googlesitekit-widgets-********************.js	19.5 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61 kB
./dist/assets/js/runtime-********************.js	1.22 kB

_{compressed-size-action}

[tofumatt]

I followed the QA steps here but when following this step in the QA brief I didn't see the dropdown:

Set the tester plugin AdSense account status to "multiple". Go to the AdSense setup. You should now see the dropdown to select an account. If you land in another situation (where your account seems as if it was already selected), it would mean the problem was not fixed as expected.

When I follow those steps I see this screen:

Here are my settings in the tester plugin:

The other QA steps seem to work fine though.

[felixarntz]

@tofumatt Two follow-up question on your QA feedback here:

1. Are you using the latest version of the tester plugin? We recently added a small follow-up fix to it so that the accounts response in case of no accounts is indeed an empty array instead of an error, which is crucial for QAing this one.
2. Did you also perform the previous step to go through the setup flow with account status set to none before? That is crucial because that should reset the accountID to be empty. If the accountID is set to one of the accounts from the multiple accounts, it bypasses the dropdown to select the account.

[tofumatt]

@felixarntz Ah, I didn't have 1.8.2 of the tester plugin, that totally fixed it! I followed the steps you outlined but I didn't have the latest one.

Thanks! 👍🏻

[tofumatt]

Tested with the new tester plugin (1.8.2) and it worked a treat. I'll add that requirement to the QA Brief and then merge this 👍🏻