Fix/ga4 setup banner progress bar

[techanvil]

Summary

Addresses issue:

• Add the dropdown and toggle controls to "existing GA4 property" setup variants #5276

Relevant technical choices

Followup fix to show a progress bar while determining which SetupBanner variant to display.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 4.7 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[github-actions]

Size Change: +614 B (0%)

Total Size: 1.5 MB

Filename	Size	Change
./dist/assets/js/googlesitekit-activation-********************.js	28.1 kB	+50 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js	36.4 kB	+430 B (+1%)
./dist/assets/js/googlesitekit-api-********************.js	9.24 kB	+1 B (0%)
./dist/assets/js/googlesitekit-dashboard-********************.js	69.1 kB	+235 B (0%)
./dist/assets/js/googlesitekit-dashboard-details-********************.js	61.4 kB	+219 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash-********************.js	71 kB	+11 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	14.9 kB	-2 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	30.3 kB	+9 B (0%)
./dist/assets/js/googlesitekit-idea-hub-post-list-********************.js	26.1 kB	-2 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js	19.5 kB	+2 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	69.6 kB	-1 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	19.1 kB	-4 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	68.2 kB	+2 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub-********************.js	27.6 kB	+6 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js	19.4 kB	+11 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	18.5 kB	+11 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	38.5 kB	+21 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	32.1 kB	-12 B (0%)
./dist/assets/js/googlesitekit-modules-thank-with-google-********************.js	25.1 kB	-7 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js	50.2 kB	+18 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js	45 kB	+59 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js	323 kB	+1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	59.4 kB	-444 B (-1%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css	48.4 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.1 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	5.97 kB
./dist/assets/js/31-********************.js	2.8 kB
./dist/assets/js/32-********************.js	2.28 kB
./dist/assets/js/33-********************.js	3.72 kB
./dist/assets/js/34-********************.js	51.9 kB
./dist/assets/js/35-********************.js	16.1 kB
./dist/assets/js/36-********************.js	70.9 kB
./dist/assets/js/37-********************.js	31.6 kB
./dist/assets/js/38-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-base-********************.js	1.13 kB
./dist/assets/js/googlesitekit-data-********************.js	2.09 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js	8.88 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.09 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js	8.97 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-idea-hub-notice-********************.js	45.1 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	380 B
./dist/assets/js/googlesitekit-widgets-********************.js	19.6 kB
./dist/assets/js/runtime-********************.js	1.34 kB

_{compressed-size-action}

[aaemnnosttv]

Thanks @techanvil – this looks good, although the stories for the "No GA4 Property" are both progress bars now – can we keep these as the resolved interface?

https://google.github.io/site-kit-wp/storybook/pull/5796/?path=/story/modules-analytics4-setupbanner--no-property-no-tag

Current
https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-analytics4-setupbanner--no-property-no-tag

[techanvil]

Thanks @techanvil – this looks good, although the stories for the "No GA4 Property" are both progress bars now – can we keep these as the resolved interface?

https://google.github.io/site-kit-wp/storybook/pull/5796/?path=/story/modules-analytics4-setupbanner--no-property-no-tag

Current https://google.github.io/site-kit-wp/storybook/develop/?path=/story/modules-analytics4-setupbanner--no-property-no-tag

Ah, thanks for spotting that @aaemnnosttv! I have pushed a fix for the stories.

[aaemnnosttv]

LGTM, thanks @techanvil!